Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages for feeds #229

Open
badboy opened this issue Jul 17, 2013 · 4 comments
Open

Better error messages for feeds #229

badboy opened this issue Jul 17, 2013 · 4 comments

Comments

@badboy
Copy link

badboy commented Jul 17, 2013

Right now I've got a lot of failing feeds and I don't know why.
failed

As the error reporting is pretty sparse (Error parsing) it's hard to figure out what went wrong (on my side or a broken feed). Looking through each feed is burdensome.

If the error would be logged correctly it would be much easier (it does not really need to be shown in the web interface, if it can be found in heroku logs I'm fine with it)

@swanson
Copy link
Collaborator

swanson commented Jul 17, 2013

Logging is kinda, sorta half implemented already (but not "turned on"): https://github.com/swanson/stringer/blob/master/app/tasks/fetch_feed.rb

But it could use some love in getting it actually working and usable. I think just getting it reporting better errors to a logfile is a good first step.

@mcfilib
Copy link

mcfilib commented Jul 18, 2013

Absolutely. I'm not even sure why these all seem to be failing. Two of them were working recently but the others are very infrequently updated. So, I'm not sure if they work at all or if they're failing because they're updated infrequently.

rss feed list image

@mherb
Copy link
Contributor

mherb commented Jul 18, 2013

@unsymbol Your feeds are most-likely marked as failing due to issues introduced in several commits recently (although the content is fetched just fine). In bf50b95, feeds returning a 304 Not Modified header would be marked as failing. 4765c1a fixed that behavior, however introduced a new issue again causing the feeds to be marked as failing, which was fixed in 47e2e0d.

Depening on which version you're on, either of these issues might have caused all the failing feeds.

So your feeds should turn green again once you're running the latest version and each feed gets updated (e.g. new stories in the feed) or (with #236 merged) when the feed gets fetched again.

@swanson
Copy link
Collaborator

swanson commented Aug 16, 2015

Closing due to lack of interest. Interested parties may re-open if you want to continue the discussion of implementation.

@swanson swanson closed this as completed Aug 16, 2015
@mockdeep mockdeep reopened this Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants