Limit actors loaded on queue (re)load #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
strideynet
requested changes
Aug 21, 2023
| actors, err := s.queries.ListCandidateActors(ctx, statusFilter) | ||
| actors, err := s.queries.ListCandidateActors(ctx, gen.ListCandidateActorsParams{ | ||
| Status: statusFilter, | ||
| Limit: opts.Limit, |
There was a problem hiding this comment.
This change breaks the CandidateActorCache as that hasn't been updated to pass a limit in - so 0 will be used. We may need to build pagination into that before we can do this 😓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits the number of actor profiles loaded in the approval queue on initial load and any subsequent refresh to 102.
While this change hides the true number of accounts in the queue, this prevents that in the admittedly unlikely but possible scenario described by Toon (internal), we can process the queue relatively performant.
In the long term, I want to show the total number of queued accounts and only load a single account—especially with how we might change how the queue is interacted with—, but for now this is a good patch.
Screenshots
Because of the limit change, the pending count now summarizes the pending count as 100+ if there are more than 100 accounts in the queue.