Support mTLS authentication for MoP #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Technoboy-:Thanks for your contribution. For this PR, do we need to update docs? |
Technoboy-
changed the title
Technoboy-
changed the title
(cherry picked from commit 9817118)
Technoboy-
force-pushed
the
add-mtls-test
branch
from
4fbc6a0
to
deabeaa
Compare
coderzc
reviewed
Sep 10, 2024
tests/src/test/java/io/streamnative/pulsar/handlers/mqtt/mqtt5/hivemq/base/ProxyMtlsTest.java
Show resolved
Hide resolved
…/hivemq/base/ProxyMtlsTest.java
coderzc
reviewed
Sep 10, 2024
mqtt-impl/src/main/java/io/streamnative/pulsar/handlers/mqtt/MQTTCommonConfiguration.java
Outdated
Show resolved
Hide resolved
…QTTCommonConfiguration.java
coderzc
changed the title
coderzc
previously approved these changes
Sep 10, 2024
gaoran10
previously approved these changes
Sep 10, 2024
mattisonchao
previously approved these changes
Sep 10, 2024
coderzc
reviewed
Sep 10, 2024
coderzc
dismissed stale reviews from mattisonchao, gaoran10, and themself
via
9af7e82
coderzc
approved these changes
Sep 10, 2024
mattisonchao
approved these changes
Sep 10, 2024
coderzc
reviewed
Sep 10, 2024
Comment on lines
+165
to
+168
| protected MQTTAuthenticationService.AuthenticationResult mtlsAuth(boolean fromProxy) throws MQTTAuthException { | ||
| return MQTTAuthenticationService.AuthenticationResult.FAILED; | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SNIP-136: https://github.com/streamnative/snip/pull/79
Support mTLS authentication for MoP
Documentation
no-need-doc