-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings caused by tests #3727
Fix deprecation warnings caused by tests #3727
Conversation
Reviewer's Guide by SourceryThis PR addresses deprecation warnings in test code by updating type hints, assertions, and function signatures. The main changes involve adding proper type annotations for Info parameters, using DirectiveValue for directive parameters, and updating test assertions to explicitly check for result.data presence. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DoctorJohn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3727 +/- ##
==========================================
- Coverage 97.02% 96.97% -0.05%
==========================================
Files 503 503
Lines 33666 33702 +36
Branches 5618 5627 +9
==========================================
+ Hits 32664 32683 +19
- Misses 795 809 +14
- Partials 207 210 +3 |
CodSpeed Performance ReportMerging #3727 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Description
This PR fixes all deprecation warnings caused directly by our test code bringing our warning count down from 109 to 53.
Running our tests still results in some deprecation warnings but those are the real ones caused by Strawberry code. I'll look at those in a separate PR so that this PR only changes code in
/tests
.Types of Changes
Summary by Sourcery
Fix deprecation warnings in test code by updating deprecated function calls and argument types, and enhance test assertions to check for result data presence.
Bug Fixes:
Tests: