From 70707d8e89f439edbd4b80030f47ff02e042693d Mon Sep 17 00:00:00 2001 From: Thiago Bellini Ribeiro Date: Mon, 3 Apr 2023 11:58:47 -0300 Subject: [PATCH] fix: do not add filters to non list fields Thanks to @g-as for reporting this regression from the last release. --- strawberry_django/filters.py | 3 +++ tests/filters/test_filters.py | 6 +++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/strawberry_django/filters.py b/strawberry_django/filters.py index ec6d3f96..fe53e2ff 100644 --- a/strawberry_django/filters.py +++ b/strawberry_django/filters.py @@ -188,6 +188,9 @@ def arguments(self) -> List[StrawberryArgument]: and self.origin._type_definition.name == "Query" ): arguments.append(argument("pk", strawberry.ID, is_optional=False)) + elif self.django_model and not self.is_list: + # Do not add filters to non list fields + pass elif filters and filters is not UNSET: arguments.append(argument("filters", filters)) return super().arguments + arguments diff --git a/tests/filters/test_filters.py b/tests/filters/test_filters.py index 4715c3ff..2cc1e509 100644 --- a/tests/filters/test_filters.py +++ b/tests/filters/test_filters.py @@ -252,7 +252,11 @@ def test_enum(query, fruits): @pytest.mark.django_db(transaction=True) def test_pk_inserted_for_root_field_only(): - @strawberry_django.type(models.Group) + @strawberry_django.filters.filter(models.Group) + class GroupFilter: + name: str + + @strawberry_django.type(models.Group, filters=GroupFilter) class GroupType(models.Group): name: strawberry.auto