Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ARM architecture support on release-bin.yaml #815

Closed
plebhash opened this issue Mar 26, 2024 · 5 comments
Closed

add ARM architecture support on release-bin.yaml #815

plebhash opened this issue Mar 26, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@plebhash
Copy link
Collaborator

plebhash commented Mar 26, 2024

Currently we only support the following platforms on the Release Binaries pipeline:

  • aarch64-apple-darwin: MacOS Apple Silicon (M1+M2)
  • x86_64-apple-darwin: MacOS x86-64
  • x86_64-linux-gnu: Linux x86-64

As described in #684, it is also desirable to support ARM SoCs and SBCs.
The two most popular architectures being:

  • aarch64-unknown-linux-gnu
  • arm-unknown-linux-gnueabi

I started working on this a while ago by proposing a shell script via PR #684, but since we have a binary release pipeline, it makes more sense add support for these targets via release-bin.yaml instead, without adding any additional shell script.

This could also be useful: https://github.com/houseabsolute/actions-rust-cross

It is a Github Action that allows cross-compilation of Rust projects via cargo cross.

While working on this issue, the contributor should make some mock releases on their fork as a way to validate that the workflow is behaving as expected.

@xyephy
Copy link
Contributor

xyephy commented Apr 10, 2024

Hi @plebhash, is it okay if I give this a try?

@xyephy
Copy link
Contributor

xyephy commented Apr 19, 2024

@plebhash I've managed to do the releases : https://github.com/xyephy/stratum/releases/tag/dev.
working file: https://github.com/xyephy/stratum/blob/dev/.github/workflows/release-bin.yaml
Used cargo cross as you had suggested.
Kindly check them out before I do a PR

@plebhash
Copy link
Collaborator Author

plebhash commented Apr 19, 2024

@plebhash I've managed to do the releases : https://github.com/xyephy/stratum/releases/tag/dev. working file: https://github.com/xyephy/stratum/blob/dev/.github/workflows/release-bin.yaml Used cargo cross as you had suggested. Kindly check them out before I do a PR

LGM

@xyephy
Copy link
Contributor

xyephy commented Apr 19, 2024

@plebhash I've managed to do the releases : https://github.com/xyephy/stratum/releases/tag/dev. working file: https://github.com/xyephy/stratum/blob/dev/.github/workflows/release-bin.yaml Used cargo cross as you had suggested. Kindly check them out before I do a PR

LGM

I've pushed PR #864

@pavlenex
Copy link
Collaborator

pavlenex commented May 1, 2024

Closed in #864

@pavlenex pavlenex closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants