Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better import for libsecp256k1 #749

Closed
lorbax opened this issue Feb 13, 2024 · 5 comments
Closed

better import for libsecp256k1 #749

lorbax opened this issue Feb 13, 2024 · 5 comments
Assignees
Milestone

Comments

@lorbax
Copy link
Collaborator

lorbax commented Feb 13, 2024

As suggested by @Fi3 in the review of #737, we should

  1. move the dependency of secp256k1 in stratum_common and import this library from there
  2. avoid to import secp256k1 in roles (it is used by the JDS for signing tokens and by the pool for verifying tokens' signature). Rather, some sort of wrapper structure in roles-logic for making and verifying signatures would be more appropriate.
@rockcoolsaint
Copy link
Contributor

I think this is something I can handle. Can I go ahead with it? @lorbax

@lorbax
Copy link
Collaborator Author

lorbax commented Apr 16, 2024

Don't know if it is really a good "first issue" but if feel comfortable you can DM on discord and discuss how to proceed

@Fi3
Copy link
Collaborator

Fi3 commented Apr 16, 2024

now you can import libs from the workspace Cargo.toml and refer to it in the crate Cargo.toml when you have common dep between crates in the same workspace.

@rockcoolsaint
Copy link
Contributor

Don't know if it is really a good "first issue" but if feel comfortable you can DM on discord and discuss how to proceed

What's your discord handle?

@plebhash
Copy link
Collaborator

closed via #894

@pavlenex pavlenex added this to the 1.0.1 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants