Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRI uses incorrect encoding of secp256k1 public keys #721

Closed
jakubtrnka opened this issue Jan 19, 2024 · 1 comment · Fixed by #722
Closed

SRI uses incorrect encoding of secp256k1 public keys #721

jakubtrnka opened this issue Jan 19, 2024 · 1 comment · Fixed by #722
Assignees
Labels
spec incompatibility Issues ensuring SRI follows the specs
Milestone

Comments

@jakubtrnka
Copy link
Contributor

jakubtrnka commented Jan 19, 2024

The specification says that public key should be encoded as
concatenation of array [1, 0] (which is version number) and 32 bytes x-only public key.
using base58-check algorithm

Currently it does direct base58 encoding of the 32 bytes public key without checksum.

See:
https://github.com/stratum-mining/sv2-spec/blob/main/04-Protocol-Security.md#47-url-scheme-and-pool-authority-key

@Sjors
Copy link
Collaborator

Sjors commented Jan 22, 2024

Ah, that's useful to know. I'll switch the correct encoding on the Bitcoin Core side after #722 is merged.

@pavlenex pavlenex added this to the Milestone4 milestone Jan 22, 2024
@pavlenex pavlenex added the spec incompatibility Issues ensuring SRI follows the specs label Jan 23, 2024
@pavlenex pavlenex linked a pull request Feb 6, 2024 that will close this issue
@Fi3 Fi3 closed this as completed in #722 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec incompatibility Issues ensuring SRI follows the specs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants