Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRI Integration Test Framework: bitcoind #1119

Closed
Tracked by #1120
plebhash opened this issue Aug 19, 2024 · 2 comments · Fixed by #1156
Closed
Tracked by #1120

SRI Integration Test Framework: bitcoind #1119

plebhash opened this issue Aug 19, 2024 · 2 comments · Fixed by #1156
Assignees
Milestone

Comments

@plebhash
Copy link
Collaborator

plebhash commented Aug 19, 2024

The second stage of #1120

Requirements:

  • Ability to launch a Template Provider (TP) process (SV2-enabled bitcoind in regtest mode) via the bitcoind crate within the new SRI Integration Tests framework described in x.
  • SRI requires that the blockchain has at least 16 blocks, so the creation of those should be automated and abstracted away from the framework user (so it doesn’t have to be done explicitly for every test).

This should be useful for tests where orchestrating a bitcoind process in regtest mode is sufficient.

There might be instances however where this is not sufficient. For example, we might want to assert some role’s behavior against an invalid template, which would be rather difficult to generate by simply orchestrating a bitcoind process without access to its internal C++ APIs.

For scenarios where this approach is not sufficient, a TP mock will be required (mocks are detailed #1122).

@plebhash plebhash changed the title bitcoind for Integration Tests SRI Integration Test Framework: bitcoind Aug 19, 2024
@plebhash plebhash added this to the 1.1.0 milestone Aug 20, 2024
@plebhash
Copy link
Collaborator Author

@jbesraa should we aim to do this together with #1066 or separate PRs?

@Shourya742
Copy link
Contributor

@plebhash Once the #1066 branch is fixed, I can push my changes as a PR to it.

@plebhash plebhash removed this from the 1.1.0 milestone Sep 3, 2024
@plebhash plebhash linked a pull request Sep 13, 2024 that will close this issue
@plebhash plebhash added this to the 1.1.0 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants