Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up stratis-dumpmetadata #3530

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Jan 6, 2024

@mulkieran mulkieran self-assigned this Jan 6, 2024
@mulkieran mulkieran changed the title Tidy up stratis-utils file Tidy up stratis-utils file and stratis-dumpmetadata Jan 6, 2024
@mulkieran mulkieran force-pushed the issue_stratisd_3529 branch 5 times, most recently from 0de5587 to 1c341af Compare January 9, 2024 17:01
@mulkieran mulkieran changed the title Tidy up stratis-utils file and stratis-dumpmetadata Tidy up stratis-dumpmetadata Jan 9, 2024
@bgurney-rh
Copy link
Member

With the current stratisd.spec file, this will fail to build (at 6dc0535) with the following error:

error: no bin target named `stratis-dumpmetadata`.

@bgurney-rh
Copy link
Member

After that, some files that now need to be listed:

error: Installed (but unpackaged) file(s) found:
   /usr/bin/stratisd-tools
   /usr/lib/debug/usr/bin/stratisd-tools-3.7.0~202401091353git6dc05353-D.el9.x86_64.debug
    Installed (but unpackaged) file(s) found:
   /usr/bin/stratisd-tools
   /usr/lib/debug/usr/bin/stratisd-tools-3.7.0~202401091353git6dc05353-D.el9.x86_64.debug

* Change name of primary binary to stratisd-tools
* Update CI
* Add struct based dispatch
* Allow invoking stratisd-tools directly with name as subcommand

Signed-off-by: mulhern <[email protected]>
@mulkieran
Copy link
Member Author

rebased. Need to drop temporary commit before merging, then merge stratis-storage/ci#499 .

@mulkieran mulkieran merged commit 6df7016 into stratis-storage:master Jan 11, 2024
36 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants