-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up stratis-dumpmetadata #3530
Merged
mulkieran
merged 2 commits into
stratis-storage:master
from
mulkieran:issue_stratisd_3529
Jan 11, 2024
Merged
Tidy up stratis-dumpmetadata #3530
mulkieran
merged 2 commits into
stratis-storage:master
from
mulkieran:issue_stratisd_3529
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
changed the title
Tidy up stratis-utils file
Tidy up stratis-utils file and stratis-dumpmetadata
Jan 6, 2024
mulkieran
force-pushed
the
issue_stratisd_3529
branch
5 times, most recently
from
January 9, 2024 17:01
0de5587
to
1c341af
Compare
mulkieran
changed the title
Tidy up stratis-utils file and stratis-dumpmetadata
Tidy up stratis-dumpmetadata
Jan 9, 2024
mulkieran
force-pushed
the
issue_stratisd_3529
branch
from
January 9, 2024 17:44
1c341af
to
6dc0535
Compare
With the current stratisd.spec file, this will fail to build (at 6dc0535) with the following error:
|
After that, some files that now need to be listed:
|
mulkieran
force-pushed
the
issue_stratisd_3529
branch
from
January 9, 2024 20:29
6dc0535
to
d3868e9
Compare
mulkieran
force-pushed
the
issue_stratisd_3529
branch
4 times, most recently
from
January 10, 2024 15:20
60b2b21
to
447b35c
Compare
jbaublitz
approved these changes
Jan 10, 2024
bmr-cymru
approved these changes
Jan 11, 2024
Signed-off-by: mulhern <[email protected]>
* Change name of primary binary to stratisd-tools * Update CI * Add struct based dispatch * Allow invoking stratisd-tools directly with name as subcommand Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
issue_stratisd_3529
branch
from
January 11, 2024 15:42
447b35c
to
a1e60dd
Compare
rebased. Need to drop temporary commit before merging, then merge stratis-storage/ci#499 . |
mulkieran
force-pushed
the
issue_stratisd_3529
branch
from
January 11, 2024 17:29
a1e60dd
to
f5972db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related stratis-storage/project#683