Send blockdev change signal on grow physical #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
force-pushed
the
issue_stratisd_3371
branch
from
b082b8b
to
5c21210
Compare
jbaublitz
requested changes
Jul 6, 2023
src/dbus_api/tree.rs
Outdated
Comment on lines
874
to
851
| prop_hashmap!( | ||
| consts::BLOCKDEV_INTERFACE_NAME_3_3 => { | ||
| Vec::new(), | ||
| consts::BLOCKDEV_TOTAL_SIZE_PROP.to_string() => | ||
| box_variant!(total_physical_size_prop.clone()) | ||
| }, | ||
| consts::BLOCKDEV_INTERFACE_NAME_3_4 => { | ||
| Vec::new(), | ||
| consts::BLOCKDEV_TOTAL_SIZE_PROP.to_string() => | ||
| box_variant!(total_physical_size_prop.clone()) | ||
| }, | ||
| consts::BLOCKDEV_INTERFACE_NAME_3_5 => { | ||
| Vec::new(), | ||
| consts::BLOCKDEV_TOTAL_SIZE_PROP.to_string() => | ||
| box_variant!(total_physical_size_prop.clone()) | ||
| }, | ||
| consts::BLOCKDEV_INTERFACE_NAME_3_6 => { | ||
| Vec::new(), | ||
| consts::BLOCKDEV_TOTAL_SIZE_PROP.to_string() => | ||
| box_variant!(total_physical_size_prop) | ||
| } | ||
| ), |
There was a problem hiding this comment.
I'm not sure this is the best thing to do here. Even if grow physical was added in r3, the total physical size property is available all the way back so theoretically even if a user is using a r3 method, we should notify them that the property in r1 (for example) has changed.
|
|
mulkieran
force-pushed
the
issue_stratisd_3371
branch
4 times, most recently
from
44d6b4a
to
5e6457b
Compare
bgurney-rh
approved these changes
Jul 7, 2023
|
The new stratisd_cert test that was added today has a --monitor-dbus failure for this DifferentProperty message: |
mulkieran
force-pushed
the
issue_stratisd_3371
branch
from
5e6457b
to
a70442b
Compare
|
rebased |
CI should be passing again w/ #3375 |
mulkieran
force-pushed
the
issue_stratisd_3371
branch
from
a70442b
to
21be659
Compare
|
rebased. |
jbaublitz
approved these changes
Jul 10, 2023
mulkieran
force-pushed
the
issue_stratisd_3371
branch
from
21be659
to
e4a6464
Compare
|
@mvollmer Please let us know if you want to test this. |
mulkieran
force-pushed
the
issue_stratisd_3371
branch
from
e4a6464
to
49351f9
Compare
|
rebased + squashed |
mulkieran
requested review from
bgurney-rh and
jbaublitz
and removed request for
mvollmer
mulkieran
force-pushed
the
issue_stratisd_3371
branch
from
cdf8947
to
dbe5456
Compare
|
Now all new and revised! |
jbaublitz
approved these changes
Jul 11, 2023
|
Squashing a bit before merging... |
Signed-off-by: mulhern <[email protected]>
From now on, if the pool size changes, then so will some other properties, so we will likely always need to go with the pool foreground change methods. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
issue_stratisd_3371
branch
from
dbe5456
to
8b34ba2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3371