-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMPRO is aggressively loading its own version of select2 on ALL admin pages #2902
Comments
Digging into this some more, check out this nicely restricted usage:
Its good that member_profile_edit and member_profile_edit are limited. But on the back end Forcing select2 into all admin pages is too aggressive. For example: See:
There is no consideration at all here for loading select2 only onto PMPRO pages. I would propose the use of |
Currently, here is the patch I am using
which seems legit for now (to stop client-yelling :( )... but, what if I am removing select2 when its needed? I think it would be wonderful if something like this was tacked on here:
or... tack on a dependency for |
Same issue here. Please resolve it. Why do you guys need to load scripts on every page is there any reason? |
Describe the bug
Very simple: PMPRO is aggressively loading its own version of select2 on ALL admin pages.
This creates problems. There are other plugins and themes out there using PRE 4.0 select2, and the newest select2 4.1.1 - a conflict then ensues.
To Reproduce
Steps to reproduce the behavior:
Screenshots
src="/wp-content/plugins/paid-memberships-pro/js/pmpro-admin.js"
Expected behavior
this ambiguous handle: "select2-js" would better be "pmpro_admin-select2-js" so we can identify and dequeue it.
Also ideal: not loading PMPRO's version of select2 on every wp-admin page would be courteous
consider that some of us are using this:
Select2 4.1.1-rc.2 | https://github.com/select2/select2/blob/master/LICENSE.md
and have modified the core to patch this issue -- Added non-passive event listener to a scroll-blocking event.
angular/components#4221
Isolating the problem (mark completed items with an [x]):
I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
meh... not really. because that would make the "bug" disappear
This bug happens with a default WordPress theme active, or Memberlite.
meh... not a fair request in this case
I can reproduce this bug consistently using the steps above.
WordPress Environment
The text was updated successfully, but these errors were encountered: