Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

The name router is ambiguous given its usage in other contexts #10

Closed
jtieri opened this issue Feb 11, 2022 · 4 comments
Closed

The name router is ambiguous given its usage in other contexts #10

jtieri opened this issue Feb 11, 2022 · 4 comments

Comments

@jtieri
Copy link
Member

jtieri commented Feb 11, 2022

router is used in a few different contexts across modules/in the SDK so perhaps renaming to ibcrouter would be less confusing

@faddat
Copy link
Contributor

faddat commented Apr 11, 2023

yes, absolutely!

we could also call it pfm, that's what we usually call this software internally

@jtieri
Copy link
Member Author

jtieri commented Apr 11, 2023

I think pfm or forward are valid choices! typically when I import the middleware into other repos I end up creating an alias called forward

This codebase will soon be migrating to the new ibc-apps repo so maybe that becomes a good time to change the name away from router

@aljo242
Copy link

aljo242 commented May 3, 2023

I think a lot of apps already rename the import to packetforward so this might be a good candidate as well.

@Reecepbcups
Copy link
Member

Moved to upstream issue now in the maintained repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants