Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmosFullNode sentry creates privval services. #351

Open
DavidNix opened this issue Sep 6, 2023 · 1 comment
Open

CosmosFullNode sentry creates privval services. #351

DavidNix opened this issue Sep 6, 2023 · 1 comment

Comments

@DavidNix
Copy link
Contributor

DavidNix commented Sep 6, 2023

Like p2p services, 1 per pod.

This is so remote signers can connect to a stable address.

We probably need to deprecate the readiness probe strategy. Readiness has to be turned off for sentries to be added to the service.

It's a chicken or egg problem. Comet tries to connect immediately and blocks thus failing readiness probes. The remote signer must connect to the sentry pod but can't if the sentry is not ready. (We have other safeguards for rollouts which now check the state of Comet.) So removing the probes should have little impact.

It's worth investigating how StatefulSets give each pod a stable network id.

The service is likely still necessary given the user may need to configure it. E.g. We used internal lb services on GKE.

@DavidNix
Copy link
Contributor Author

DavidNix commented Sep 28, 2023

We really want to explore using the pod's stable DNS name given #360 instead of creating a service for each pod. But advantage to a service is you can configure it more, such as internal LB IPs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant