Skip to content

onClick(boolean) warning in rating.js #14

Open
@qwadzie

Description

@qwadzie

warning in chrome: Warning: Expected onClick listener to be a function, instead got a value of boolean type. It still works though.
for this code in render():
onClick={!this.props.readonly && this.setRating.bind(this, i)}
onMouseOver={!this.props.readonly && this.setTemp.bind(this, i)}
Instead, if you do this, no warning:
onClick = { !this.props.readonly ? this.setRating.bind(this,i) : null}
onMouseOver= { !this.props.readonly ? this.setTemp.bind(this,i) : null}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions