Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: implement equivalent to Playwright’s .toPass or .poll #533

Open
ihsib opened this issue Jan 22, 2025 · 0 comments
Open
Labels
feature request New feature or request needs triage

Comments

@ihsib
Copy link

ihsib commented Jan 22, 2025

Is your feature request related to a problem? Please describe.

We are currently facing issues with Storybook runner visual tests failing due to incomplete hydration. We’ve experimented with both the mask feature , waitForPageReady and the waitFor method using Promise.all and custom polling, but the results remain inconsistent. Additionally, we’ve noticed that sometimes the masked elements seem to shift, causing tests to fail.

Describe the solution you'd like

Given that the Playwright package is already used in the Storybook runner, we suggest integrating the .toPass or .toPoll method. This could help improve the reliability of our visual tests by providing more consistent and readable assertions.

https://playwright.dev/docs/test-assertions#expecttopass

https://playwright.dev/docs/test-assertions#expectpoll

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

no

Additional context

No response

@ihsib ihsib added feature request New feature or request needs triage labels Jan 22, 2025
@ihsib ihsib changed the title [Feature request]: implement equivalent to Playwrigts .toPass or .poll [Feature request]: implement equivalent to Playwright’s .toPass or .poll Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

1 participant