Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and package structure to support ESM #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update dependencies and package structure to support ESM #51

wants to merge 2 commits into from

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 24, 2024 •
edited by github-actions bot
Loading

Closes #49
Relates to storybookjs/storybook#26291

This PR does the following:

  • Replace TSC+Babel with TSUP for building the addon
  • Refactor the library accordingly
  • Stop using require in viteFinal so vite doesn't use CJS
  • Upgrade vite-plugin-istanbul from 3.x to 6.x
  • Adds some tests in the stories to check that coverage exists
📦 Published PR as canary version: 2.0.0--canary.51.dcd0bca.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@yannbf yannbf added the major Increment the major version when merged label Dec 24, 2024
@yannbf yannbf self-assigned this Dec 24, 2024
@yannbf yannbf requested a review from kasperpeulen as a code owner December 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen kasperpeulen is a code owner

Assignees

@yannbf yannbf

Labels
major Increment the major version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The CJS build of Vite's Node API is deprecated.
2 participants
@yannbf @valentinpalkovic