Skip to content
This repository was archived by the owner on Dec 12, 2018. It is now read-only.
This repository was archived by the owner on Dec 12, 2018. It is now read-only.

Please log "invalid JWT in refresh_token cookie" as just an error (without an exception) #1076

Open
@george-hawkins-work

Description

@george-hawkins-work

Currently we run tests where we do things such as create and delete users and test that the given user can no longer access anything.

When we do this we see a reasonable Stormpath error message in our logs:

Encountered invalid JWT in refresh_token cookie. We will now delete both the access and refresh cookies for safety.

These messages though are always accompanied by an exception stack trace. But this is a handled situation - the system knows what's going on and has reacted to it.

Generally I think logging stack traces should be reserved for situations where the system isn't quite sure what's happened and is logging where things went wrong so that someone can debug the point of failure (possibly at an unknown point far away from where the exception has been caught).

Currently we treat exceptions in our logs as indications that something is probably broken. This is not the case in this situation. Our QA investigates any exceptions that get logged - so currently this exception has to be put in a special category of expected exceptions.

Perhaps log the message at log level ERROR and the exception at log level DEBUG if you're worried that the exception may not always indicate a JWT issue (you are after all catching Exception e rather than a JWT specific exception).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions