Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make limiting features consistent across Gateway-MT and Link Sharing Service #525

Open
amwolff opened this issue Nov 18, 2024 · 1 comment
Open

make limiting features consistent across Gateway-MT and Link Sharing Service #525

amwolff opened this issue Nov 18, 2024 · 1 comment
Labels
edge Gateway-MT linksharing Needs Estimation

Comments

@amwolff
Copy link
Member

amwolff commented Nov 18, 2024

Goal

Gateway-MT has the per-macaroon head rate limiter and linksharing has a limit on the total number of requests as well as the ability to block certain paths. It would be valuable to make these options consistent.

Acceptance Criteria

  • Implement the limit on the total number of requests in GW-MT
  • Implement the per-macaroon head rate limiter in linksharing
  • Make the per-macaroon head rate limiter have the ability to rate limit project IDs as well
  • Make limiting options consistent under the same configuration key (e.g., --limits.[…])

Links
@amwolff amwolff mentioned this issue Dec 16, 2024
Open
@storj-gerrit
Copy link

storj-gerrit bot commented Dec 17, 2024

Change pkg/{minio,server/middleware}: use project for concurrent req limiter mentions this issue.

storjBuildBot pushed a commit that referenced this issue Jan 6, 2025
@halkyon
pkg/{minio,server/middleware}: use project for concurrent req limiter
5b6c34f 
this changes the concurrent requests limiter to use public project
ID if the authservice record contains it.

Updates #525

Change-Id: I67ae2ad52f74db0a1446cc3dd3f7f81024c1a114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
edge Gateway-MT linksharing Needs Estimation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amwolff