Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url/baseUrl confusion #61

Open
XVincentX opened this issue Feb 22, 2020 · 2 comments
Open

url/baseUrl confusion #61

XVincentX opened this issue Feb 22, 2020 · 2 comments
Assignees

Comments

@XVincentX
Copy link
Contributor

The URL property here is kind of confusing

https://github.com/stoplightio/types/blob/master/src/http.ts#L18

since it makes you think it's a full URL but there are no query Parameters. I suggest we find a better nomenclature for this part so that's clear and we do not get in trouble.

We've been confused couple of times while using this property in Request Maker

@marbemac
Copy link
Contributor

Hmm - any suggestions? We could add an additional sentence to the comment indicating query params should go on the query property and not be included in the URL? This property was initially inspired by the axios request object: https://github.com/axios/axios#request-config.

@XVincentX
Copy link
Contributor Author

@marbemac I would really follow the same convention of URIJS

image

Feels complete and will address the confusion forever and ever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants