Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add Offset and Crop coordinates #47

Open
kelexel opened this issue Apr 20, 2017 · 0 comments
Open

[Enhancement] add Offset and Crop coordinates #47

kelexel opened this issue Apr 20, 2017 · 0 comments

Comments

@kelexel
Copy link

kelexel commented Apr 20, 2017

Hello !

Well, first, kudos to @stomita for finding this hack!
I can confirm this to be working on iOS7!

I plan to use this lib as a fallback for < iOS8 devices in my project.

I need squared images, so I managed to add a destOffsetX and destOffsetY settings.

But I would also need to crop portion (sX, sY, sW, sH) of the image..
And this is where part of the logic of the code eludes me.

While I can easily pin this to renderImageToCanvas(), I cannot figure how my sX, sY, sW, sH would interact in the two while() loops.

If anyone has a clue, that would be appreciated, as I have to admit, leaving iOS7 behind because of such canvas issues, kind of makes me... Hrmm... Unhappy.

Ps: If anyone wants my squared-offseted-image-mod, please drop a line, I will fill a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant