Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verse of the day should be changed based on date and not day number #10

Open
stoiandan opened this issue Jun 26, 2021 · 1 comment
Open

Verse of the day should be changed based on date and not day number #10

stoiandan opened this issue Jun 26, 2021 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@stoiandan
Copy link
Owner

Currently in src/verseOfTheDay.js there is mechanism in place to check each time the verse of the day is request, if it has expired or not (i.e. if it's still the same day), this has been implemented by comparing day numbers (example Sunday = 1, Monday = 2), instead of whole dates (i.e. 23.05.2021).
This is a bug because if a user only uses the browser on, say, Sundays, the mechanism will conclude it's the same date, which is wrong, and not fetch a new verse of the day.
@stoiandan stoiandan added bug Something isn't working good first issue Good for newcomers labels Jun 26, 2021
@Ajay-006
Copy link

I made a bug fix contribution for this issue. Actually this is my very first contribution. I want to know whether my fix is worked perfectly or not ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stoiandan @Ajay-006