fix

Author: burrbull

CHANGELOG.md

@@ -7,11 +7,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+### Added
+
+ - initial `embedded-io` support [#725]
+
 ### Changed
 
  - Use `stm32f4-staging` until `stm32f4` is released [#706]
 
 [#706]: https://github.com/stm32-rs/stm32f4xx-hal/pull/706
+[#725]: https://github.com/stm32-rs/stm32f4xx-hal/pull/725
 
 ## [v0.21.0] - 2024-05-30
 

src/serial/hal_1.rs

@@ -126,32 +126,6 @@ mod io {
         <USART as Instance>::RegisterBlock: RegisterBlockImpl,
         USART: Deref<Target = <USART as Instance>::RegisterBlock>,
     {
-        /*
-        fn write(&mut self, bytes: &[u8]) -> Result<usize, Self::Error> {
-            let mut iter = bytes.iter();
-            let Some(first) = iter.next() else {
-                return Ok(0);
-            };
-            // block for first byte
-            self.usart.write_u8(*first)?;
-            let mut i = 1;
-
-            // write more bytes if it's possible
-            for byte in iter {
-                match self.usart.write_u8(*byte) {
-                    Ok(_) => {
-                        i += 1;
-                    }
-                    Err(nb::Error::WouldBlock) => {
-                        return Ok(i);
-                    }
-                    Err(nb::Error::Other(e)) => {
-                        return Err(e);
-                    }
-                }
-            }
-            Ok(i)
-        }*/
         fn write(&mut self, bytes: &[u8]) -> Result<usize, Self::Error> {
             let mut i = 0;
             for byte in bytes.iter() {