NPE prevents reviewing further findings

[salsolatragus]

When I upload 22 findings to a review site (ex2) that has default_ex2_review_size = 20, I cannot review finding 21, because there's a NPE

[2018-05-24 14:04:03] mubench.CRITICAL: Error: Call to a member function getReview() on null in .../src/Controllers/ReviewsController.php:51

The NPE occurs here. It's the logic that determines the next/current/previous misuse that returns null for the current misuse. Interestingly, when I set default_ex2_review_size = 21, I can successfully review finding 21, but I (still) cannot review finding 22, so somehow the default impacts the querying here.

[joschli]

How exactly do you try to access the review page of the finding when you get the error ?
I can only reproduce this error by changing the url to a misuse that isn't shown on my detector page.

[salsolatragus]

• Fix passing of ex2_review_size in guest mode
• Fix navigation for "outside of range" (either back -> n - 1, forward -> 1, or back = null, forward = null)