Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n support. #55

Open
nonsoft-dev opened this issue Dec 17, 2020 · 5 comments
Open

Add i18n support. #55

nonsoft-dev opened this issue Dec 17, 2020 · 5 comments

Comments

@nonsoft-dev
Copy link

Hi there.

Please forgive me writing this issue in English, my Chinese isn't very well.

I was super interested in this project and wanted to have i18n - multiple languages support. I have made a fork of this project to support those who needs to add language of your own.

https://github.com/nonsoft-dev/live2d-widget-i18n

The idea is to swap the waifu language in real-time.

image

This requires i18n-js dependency and I have modified quite a bit of codes without proper testing. Therefore, I'll not make a pull request to add in but I think it's great to share for those who're looking for the same thing as me :).

Thank you for such an awesome widget 🎊 🎊.

Keep up with the great work!

@zhanghexiangcn
Copy link

Great!

@stevenjoezhang stevenjoezhang pinned this issue Jan 13, 2021
@KnowsCount
Copy link

KnowsCount commented Feb 12, 2021

this is a great idea. @nonsoft-dev why don't you make a pull request? I wonder if you can open a pull request here in my repo https://github.com/KnowsCount/qiokian (the same thing but a vue component) too... It would be fabulous if you can! If you cannot due to reasons, may I personally merge it into my repo?

@nonsoft-dev
Copy link
Author

nonsoft-dev commented Mar 11, 2021

@KnowsCount Thank you. Sorry I wasn't able to check Github recently. I didn't make a pull request because I just feel like it will add extra unnecessary dependencies to this project.

Please feel free to merge in with your repo :).

@stevenjoezhang
Copy link
Owner

Sorry for the late reply, I have been very busy in the past few months.

I didn't expect this project to become so popular at first, so I didn't design enough API to ensure the extensibility of the plugin.

Now I am considering redesigning some APIs so that even users who are not proficient in javascript can customize more content, including i18n and more functional buttons (e.g. #64).

This may take some time and bring breaking changes that are not backward compatible.

If you have better suggestions, you can also reply in this issue. Thanks 😊

@stevenjoezhang
Copy link
Owner

I have recently made some refactors so that you could easily customize almost all the text in waifu-tips.json, without modifying waifu-tips.js

This should make the translation a little easier, and the i18n support can be implemented by keeping multilingual versions of waifu-tips.json in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants