Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's Map this baby! #62

Open
MappingKat opened this issue Jul 1, 2015 · 8 comments
Open

Let's Map this baby! #62

MappingKat opened this issue Jul 1, 2015 · 8 comments

Comments

@MappingKat
Copy link
Collaborator

No description provided.

@ughitsaaron
Copy link
Contributor

This is a great idea! What'd be the best way to get lat/long data for mapping?

@MappingKat
Copy link
Collaborator Author

We could probably use a geocoding library. We can convert them to a CSV and then run them through a node script or something. Or we could just manually do that...

@cluhring
Copy link
Contributor

Hey MappingKat, I just submitted a pull request. Let me know what you think? 🌎 🍕

@ughitsaaron
Copy link
Contributor

@cluhring This is a great! 👍 👏 🌎 🍕

It looks like the makers on the map correspond to each restaurant's city but not the actual address of the restaurant. I'm wondering if there's a way to get the address of each restaurant and map that for more accuracy?

The README only gives us the city, name of the restaurant, and a link (possibly to a Yelp page or the restaurant's website).

Just brainstorming some options:

  • Do it by hand. Future contributions to the README could optionally include a street address (since we already have the city) or coordinates if they want their restaurant included in the map. (I think this sounds like the way to go.)
  • Scraping a Yelp page or a restaurant's website for an address.
  • 💁

@ughitsaaron
Copy link
Contributor

@MappingKat @cluhring Check out #76 and let me know what you think.

@cluhring
Copy link
Contributor

w00t! 👍
Nice job @aptkf!
My geocoding by city was hacky, to say the least.

@ughitsaaron
Copy link
Contributor

Thanks @cluhring. You worked with what you had!

@ETNOL
Copy link
Contributor

ETNOL commented Aug 19, 2015

I have an old library I made for marking travel suggestions. Its consumes javascript objects from Firebase but I can rip that out and supply a json array instead. https://github.com/ETNOL/Travel-Map
It was my first real project so I wouldn't mind sprucing it up a bit if it would work for this.

I forget how github pages work now. Perhaps we can add an index.html and a gh-pages branch to make a page out of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants