Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ignore folders in already ignored folder #68

Open
pkuczynski opened this issue Apr 3, 2021 · 2 comments
Open

Do not ignore folders in already ignored folder #68

pkuczynski opened this issue Apr 3, 2021 · 2 comments
Labels
enhancement

Comments

@pkuczynski
Copy link

I had this output when running asimov:

/Users/yyy/Projects/xxx/node_modules/postcss-minify-params/node_modules has been excluded from Time Machine backups

There should be no need to do that, as /Users/yyy/Projects/xxx/node_modules/ is already ignored...
@stevegrunwell
Copy link
Owner

Hey @pkuczynski, thank you for bringing this to our attention! Checking to see (at the very least) if one of the parent directories matches the directory being searched for (e.g. a node_modules/ directory within a node_modules/ directory) could reduce the number of hits and speed up the process.

@Eneris
Copy link

Eneris commented Jan 8, 2024

+1 on this

VladRassokhin added a commit to VladRassokhin/asimov that referenced this issue Oct 23, 2024
@VladRassokhin
Skip checking already excluded directories
33be47c 
Using `mdfind` since it's fast, yet it may not return all excluded directories

Kinda fixes stevegrunwell#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevegrunwell @pkuczynski @Eneris