Version 2.4.0 (#31)

Author: stertooy

.codecov.yml

@@ -17,7 +17,5 @@ comment:
 
 ignore:
   - "*.g"
-  - "lib/SafeMode.gi"
-  - "lib/PcpGroup/SafeMode_Pcp.gi"
   - "tst/**"
   - "doc/**"

.github/workflows/CI.yml

@@ -7,19 +7,22 @@ on:
 jobs:
 
   test:
-    name: "Test on GAP-${{ matrix.gap-branch }}"
+    name: "Test on GAP-${{ matrix.gap-version }}"
     runs-on: ubuntu-latest
-    if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) }}
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name 
+    
     strategy:
       fail-fast: false
       matrix:
         include:
-          - gap-branch: "master"
+          - gap-version: "master"
             coverage: true
-          - gap-branch: "4.13"
+          - gap-version: "4.14.0"
+          - gap-version: "4.13.1"
+          - gap-version: "4.13.0"
 
     container:
-      image: ghcr.io/stertooy/gda-image:${{ matrix.gap-branch }}-slim
+      image: ghcr.io/stertooy/gda-image:${{ matrix.gap-version }}-slim
 
     steps:
 
@@ -37,7 +40,7 @@ jobs:
         uses: sTertooy/gda-test-pkg@v1
         with:
           COVERAGE: ${{ matrix.coverage }}
-
+            
       - name: "Process coverage"
         uses: stertooy/gda-coverage@v1
         if: ${{ matrix.coverage }}
@@ -46,13 +49,14 @@ jobs:
         uses: codecov/codecov-action@v5
         if: ${{ matrix.coverage }}
         with:
+          verbose: true
           token: ${{ secrets.CODECOV_TOKEN }}
           fail_ci_if_error: true
 
   manual:
     name: "Build manual"
     runs-on: ubuntu-latest
-    if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) }}
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name 
 
     container:
       image: ghcr.io/stertooy/gda-image:tex-slim

.github/workflows/testinstall.yml

@@ -5,18 +5,19 @@ on:
 
 jobs:
   test:
-    name: "Test on GAP-${{ matrix.gap-branch }}"
+    name: "Test on GAP-${{ matrix.gap-version }}"
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         include:
-          - gap-branch: "master"
-          - gap-branch: "4.13"
-          - gap-branch: "4.12"
+          - gap-version: "master"
+          - gap-version: "4.14.0-beta1"
+          - gap-version: "4.13.1"
+          - gap-version: "4.13.0"
 
     container:
-      image: ghcr.io/stertooy/gda-image:${{ matrix.gap-branch }}-slim
+      image: ghcr.io/stertooy/gda-image:${{ matrix.gap-version }}-slim
 
     steps:
 

.github/workflows/testpackagecompat.yml

@@ -5,18 +5,19 @@ on:
 
 jobs:
   test:
-    name: "Test on GAP-${{ matrix.gap-branch }}"
+    name: "Test on GAP-${{ matrix.gap-version }}"
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         include:
-          - gap-branch: "master"
-          - gap-branch: "4.13"
-          - gap-branch: "4.12"
+          - gap-version: "master"
+          - gap-version: "4.14.0-beta1"
+          - gap-version: "4.13.1"
+          - gap-version: "4.13.0"
 
     container:
-      image: ghcr.io/stertooy/gda-image:${{ matrix.gap-branch }}-full
+      image: ghcr.io/stertooy/gda-image:${{ matrix.gap-version }}-full
 
     steps:
 

.github/workflows/teststandard.yml

@@ -5,18 +5,19 @@ on:
 
 jobs:
   test:
-    name: "Test on GAP-${{ matrix.gap-branch }}"
+    name: "Test on GAP-${{ matrix.gap-version }}"
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         include:
-          - gap-branch: "master"
-          - gap-branch: "4.13"
-          - gap-branch: "4.12"
+          - gap-version: "master"
+          - gap-version: "4.14.0-beta1"
+          - gap-version: "4.13.1"
+          - gap-version: "4.13.0"
 
     container:
-      image: ghcr.io/stertooy/gda-image:${{ matrix.gap-branch }}-slim
+      image: ghcr.io/stertooy/gda-image:${{ matrix.gap-version }}-slim
 
     steps:
 

CHANGES.md

@@ -1,6 +1,24 @@
 This file describes changes in the GAP package TwistedConjugacy.
 
 
+2.4.0 (2024-12-05)
+------------------
+
+- Added methods for intersections of arbitrary subgroups and cosets in
+  PcpGroups
+- Added method to test membership in a double coset of a PcpGroup
+
+- Algorithms for infinite polycyclic groups again require the Polycyclic
+  package, since many methods would otherwise run forever due to the lack of
+  finiteness checks in existing methods
+
+- Renamed FullReidemeisterSpectrum to TotalReidemeisterSpectrum, to avoid
+  confusion with a spectrum being 'full'
+  
+- Replaced ToggleSafeMode@TwistedConjugacy by variable ASSERT@TwistedConjugacy
+
+
+
 2.3.0 (2024-09-17)
 ------------------
 
@@ -14,6 +32,7 @@ This file describes changes in the GAP package TwistedConjugacy.
   those in Polycyclic) to check for any errors.
 
 
+
 2.2.0 (2024-02-13)
 ------------------
 
@@ -31,6 +50,7 @@ This file describes changes in the GAP package TwistedConjugacy.
   being loaded
 
 
+
 2.1.0 (2023-03-16)
 ------------------
 
@@ -55,6 +75,7 @@ This file describes changes in the GAP package TwistedConjugacy.
   as input, and will try to solve the multiple twisted conjugacy problem
 
 
+
 2.0.0 (2021-05-01)
 ------------------
 
@@ -110,6 +131,7 @@ This file describes changes in the GAP package TwistedConjugacy.
 - Finite PcpGroups will now automatically be converted to PcGroups
 
 
+
 1.0.1 (2020-06-07)
 ------------------
 
@@ -119,6 +141,7 @@ This file describes changes in the GAP package TwistedConjugacy.
 - Updated documentation to include examples
 
 
+
 1.0.0 (2020-02-19)
 ------------------
 

CITATION CITATION.cff

@@ -10,8 +10,8 @@ preferred-citation:
   authors:
     - family-names: "Tertooy"
       given-names: "Sam"
-  version: 2.3.0
+  version: 2.4.0
   notes: "GAP Package"
-  month: 9
+  month: 12
   year: 2024
   url: "https://stertooy.github.io/TwistedConjugacy/"

LICENSE LICENSE.txt

@@ -2,8 +2,8 @@ SetPackageInfo( rec(
 
 PackageName := "TwistedConjugacy",
 Subtitle := "Computation with twisted conjugacy classes",
-Version := "2.3.0",
-Date := "17/09/2024",
+Version := "2.4.0",
+Date := "05/12/2024",
 License := "GPL-2.0-or-later",
 
 Persons := [
@@ -44,8 +44,6 @@ ArchiveURL      := Concatenation(
 
 ArchiveFormats := ".tar.gz",
 
-Status := "dev",
-
 AbstractHTML := """
     The TwistedConjugacy package provides methods to calculate Reidemeister
     classes, numbers, spectra and zeta functions, as well as other methods
@@ -70,7 +68,7 @@ Dependencies := rec(
 Extensions := [
     rec(
         needed := [ [ "Polycyclic", "2.16" ] ],
-        filename := "read_pcpgroup.g"
+        filename := "read_pcp.g"
     )
 ],
 

PackageInfo.g

@@ -14,14 +14,21 @@ by Sam Tertooy <[email protected]>
 About
 -----
 
-The TwistedConjugacy package provides methods to calculate Reidemeister
-classes, numbers, spectra and zeta functions, as well as coincidence groups of
-group homomorphisms. These methods are, for the most part, designed to be used
-with (group homomorphisms between) finite groups and, if the package Polycyclic
-is also installed and loaded, polycyclically presented groups.
+The TwistedConjugacy package provides methods to solve the twisted conjugacy
+(search) problem, calculate Reidemeister classes, numbers, spectra and zeta
+functions, as well as construct coincidence groups of group homomorphisms.
 
+These methods are, for the most part, designed to be used on (group
+homomorphisms between) finite and polycyclic groups, the latter requiring
+the use of the Polycyclic package.
 
-This package requires GAP version 4.13 or later.
+Moreover, if Polycyclic is loaded, this package also allows calculating
+intersections of arbitrary subgroups and cosets, as well as solving the
+membership problem for double cosets in polycyclic groups.
+
+
+This package requires GAP version 4.13 or later. The extension for 
+polycyclically presented groups requires Polycyclic version 2.16 or later.
 
 
 
@@ -34,7 +41,7 @@ the TwistedConjugacy package using the following command:
 
     gap> LoadPackage("TwistedConjugacy");
 	─────────────────────────────────────────────────────────────────────────────
-	Loading  TwistedConjugacy 2.3.0 (Computation with twisted conjugacy classes)
+	Loading  TwistedConjugacy 2.4.0 (Computation with twisted conjugacy classes)
 	by Sam Tertooy (https://stertooy.github.io/).
 	Homepage: https://stertooy.github.io/TwistedConjugacy/
 	Report issues at https://github.com/stertooy/TwistedConjugacy/issues