feat: ✨ include hba1c criteria #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
reviewed
May 30, 2024
| data |> | ||
| column_names_to_lower() |> | ||
| dplyr::filter({{ hba1c_criteria }}) |> | ||
| # Keep only the columns we need. |
There was a problem hiding this comment.
This is the smallest comment ever, but do we want to end inline comments with . or not?
There was a problem hiding this comment.
Hmm, good question. I don't have a strong opinion. I tend to use periods because if there are two sentences, would the second sentence end in a period or not end in one? If it ends in one, it won't match the other comments. But if it doesn't end in one, it seems a bit strange because the previous sentence has a period.
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
Aastedet
reviewed
Jun 14, 2024
|
I'll merge this in now, since it's had several rounds of reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is untested, since it depends on #101. Once that is merged, I'll be able to test these.
The
get_algorithm_logic()will extract the data from the algorithm csv file, once it is there.Closes #93