Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor csr logic to context source caller #1311

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

thomasBousselin
Copy link
Contributor

No description provided.

@thomasBousselin thomasBousselin self-assigned this Jan 9, 2025
@thomasBousselin thomasBousselin linked an issue Jan 9, 2025 that may be closed by this pull request
@thomasBousselin thomasBousselin force-pushed the refacto/migrate-csr-logic branch from 7428f65 to 975dcc6 Compare January 10, 2025 12:42
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Test Results

   71 files  ±0     71 suites  ±0   1m 28s ⏱️ -1s
1 154 tests +2  1 154 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 193 runs  +2  1 193 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit a9c4cf9. ± Comparison against base commit 6924af3.

This pull request removes 198 and adds 46 tests. Note that renamed tests count towards both.
                           …, temporalRepresentation=TEMPORAL_VALUES, withAudit=false, expectation={
                      "@id": "https://uri…
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
…
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ distributeQueryEntitiesOperation should return the warnings sent by the CSRs and update the statuses()
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ distributeRetrieveEntityOperation should return the warnings sent by the CSRs and update the statuses()
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ getDistributedInformation should always ask for the normalized representation()
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ getDistributedInformation should not ask context source for a GeoJson representation()
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ getDistributedInformation should return MiscellaneousPersistentWarning when receiving error 401()
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ getDistributedInformation should return a MiscellaneousWarning if it receives no answer()
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ getDistributedInformation should return null when receiving an error 404()
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ queryEntities ContextSource should return a RevalidationFailedWarning when receiving bad payload()
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ queryEntitiesFromContextSource should return the count and the entities when the request succeed()
com.egm.stellio.search.csr.service.DistributedEntityConsumptionServiceTests ‑ retrieveEntityContextSource should return a RevalidationFailedWarning when receiving bad payload()
…

♻️ This comment has been updated with latest results.

@thomasBousselin thomasBousselin marked this pull request as ready for review January 10, 2025 12:51
@bobeal
Copy link
Member

bobeal commented Jan 10, 2025

please write "refactor", it's only one more letter and it is a real word

@thomasBousselin thomasBousselin changed the title Refacto csr logic to context source caller Refactor csr logic to context source caller Jan 13, 2025
@thomasBousselin thomasBousselin force-pushed the refacto/migrate-csr-logic branch from 3ba9204 to 80c2cff Compare January 13, 2025 08:22
} returns (
listOf(
MiscellaneousWarning("message with\nline\nbreaks", csr),
MiscellaneousWarning("message", csr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why two warning messages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be one but since it is a list it make sens to test multiple. Also i wanted to test one message with line break and one without.

@thomasBousselin thomasBousselin merged commit 991c7bb into develop Jan 15, 2025
11 checks passed
@thomasBousselin thomasBousselin deleted the refacto/migrate-csr-logic branch January 15, 2025 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolate ContextSource logic in its own layer.
3 participants