-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor csr logic to context source caller #1311
Conversation
search-service/src/test/kotlin/com/egm/stellio/search/entity/web/EntityHandlerTests.kt
Show resolved
Hide resolved
search-service/src/test/kotlin/com/egm/stellio/search/entity/web/EntityHandlerTests.kt
Show resolved
Hide resolved
7428f65
to
975dcc6
Compare
Test Results 71 files ±0 71 suites ±0 1m 28s ⏱️ -1s Results for commit a9c4cf9. ± Comparison against base commit 6924af3. This pull request removes 198 and adds 46 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
please write "refactor", it's only one more letter and it is a real word |
search-service/src/main/kotlin/com/egm/stellio/search/csr/service/ContextSourceCaller.kt
Outdated
Show resolved
Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/csr/service/ContextSourceCaller.kt
Outdated
Show resolved
Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/csr/service/ContextSourceCaller.kt
Outdated
Show resolved
Hide resolved
search-service/src/test/kotlin/com/egm/stellio/search/csr/service/ContextSourceCallerTests.kt
Show resolved
Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/entity/web/EntityHandler.kt
Show resolved
Hide resolved
3ba9204
to
80c2cff
Compare
Quality Gate passedIssues Measures |
} returns ( | ||
listOf( | ||
MiscellaneousWarning("message with\nline\nbreaks", csr), | ||
MiscellaneousWarning("message", csr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why two warning messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be one but since it is a list it make sens to test multiple. Also i wanted to test one message with line break and one without.
No description provided.