Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the build process to a single build tool #1004

Open
janewang opened this issue Jul 9, 2024 · 5 comments
Open

Consolidate the build process to a single build tool #1004

janewang opened this issue Jul 9, 2024 · 5 comments

Comments

@janewang
Copy link

janewang commented Jul 9, 2024

Modernization of the Build System: While great strides have been made in upgrading the stack from Webpack 4 to Webpack 5 (see, for example, stellar-base#584), there’s still much more to be done. There are far superior build systems out there today that will lead to smaller and faster bundle sizes for downstream systems. We can also make the effort to support a newer package manager, like modern npm or Yarn 3.

This may or may not require downstream systems to also adapt to the new build system.

@janewang janewang changed the title Consolidate the build process to a single build tool [Spike] Consolidate the build process to a single build tool Jul 9, 2024
@janewang
Copy link
Author

janewang commented Sep 3, 2024

  • remove axios - ready for review
  • eventSource - ready for review
  • react-native - testing framework needs more research (node pkg to remove some packages for non-browser)

@janewang
Copy link
Author

Tree shaking is most likely build in according to @BlaineHeffron. Disable axios for node will be done through tree shaking

@BlaineHeffron
Copy link
Contributor

React native requires a workaround even if you use the no-eventsource version of the SDK. Here is what worked for me:

in the metro config:
let blacklistedModules = ["eventsource"];

  resolver: {
    resolveRequest: (context, moduleName, platform) => {
      if (blacklistedModules.includes(moduleName)) {
        return {
          filePath: path.resolve(__dirname + "/empty-module.js"),
          type: "sourceFile"
        };
      } else {
        return OriginalResolver.resolve(
          { ...context, resolveRequest: undefined },
          moduleName,
          platform
        );
      }
    }
  }

Create a blank file empty-module.js.

The no-eventsource and no-axios versions were merged in #1066 and #1038

@Shaptic
Copy link
Contributor

Shaptic commented Oct 7, 2024

Heroic accomplishment, can be closed I think 👍

@Shaptic Shaptic closed this as completed Oct 7, 2024
@janewang janewang reopened this Oct 8, 2024
@janewang janewang changed the title [Spike] Consolidate the build process to a single build tool Consolidate the build process to a single build tool Oct 8, 2024
@janewang
Copy link
Author

janewang commented Oct 8, 2024

Consolidated to a single build tool is has not been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo (Ready for Dev)
Development

No branches or pull requests

4 participants