Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players able to take items out of GUI when unsupported server version is used #1822

Open
Toseflo opened this issue Nov 4, 2024 · 0 comments

Comments

@Toseflo
Copy link

Toseflo commented Nov 4, 2024

I really like your inventory framework, but I noticed something, which is a critical problem for me.

I ran a plugin using IF 0.10.17 on a 1.21.3 server. At first, the chest GUI was able to open without any issues. But then, when I clicked on an item, the click event failed with an “UnsupportedVersionException: The server version provided is not supported”. The click event wasn't cancelled, and I was able to take the item out of the inventory.

Since I plan to build GUIs with custom items, players should never be able to take them out of the GUI, even with unsupported server versions. For me, it would be better if the GUI wouldn't open at all, so that players can't access the items.

So I was wondering, could you add some checks on plugin initialization, which prevents the plugin from loading when an unsupported server version is used? This would give me peace of mind, that players will never be able to gain access to items from the GUI, even when I am a bit slower with updating my plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants