Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Rejected requests counter always being updated and saved. #57

Open
jcyktor opened this issue May 16, 2016 · 0 comments
Open

Rejected requests counter always being updated and saved. #57

jcyktor opened this issue May 16, 2016 · 0 comments

Comments

@jcyktor
Copy link

jcyktor commented May 16, 2016

Per the ReadMe:

By default, rejected calls are not added to the throttle counter.
...
If you want rejected requests to count towards the other limits, you'll have to set StackBlockedRequests to true.

Looking at the code, I can see that Repository.Save is called within ThrottlingCore.ProcessRequest, which is called from ThrottlingFilter roughly 10 lines before the overlimit check is performed.

Screenshot from Redis showing a counter of 13 (this was with a perMinute limit of 10):
overlimit_requests

I've tried this with setting StackBlockedRequests explicitly to false as well as leaving the default, both with the same result.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant