Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: steelbrain/linter-ui-default
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.9
Choose a base ref
...
head repository: steelbrain/linter-ui-default
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Sep 15, 2017

  1. Simplify and fix alignment of status bar icons

    Simplify how the status bar icons are being generated, bringing them
    inline with how other status bar "widgets" are using similar icons.
    Arcanemagus committed Sep 15, 2017
    Copy the full SHA
    82486cc View commit details
  2. Merge pull request #439 from steelbrain/arcanemagus/status-bar-icon-a…

    …lignment
    
    Simplify and fix alignment of status bar icons
    Arcanemagus authored Sep 15, 2017
    Copy the full SHA
    e62c1f1 View commit details
  3. Prepare v1.6.10 release

    Arcanemagus committed Sep 15, 2017
    Copy the full SHA
    9f1cfcd View commit details

Commits on Sep 26, 2017

  1. Copy the full SHA
    dbb40d1 View commit details

Commits on Oct 10, 2017

  1. Enhancement

    Add a button to tooltip panel for fixing error if error could be fixed.
    Just like atom-ide-ui
    yubaoquan committed Oct 10, 2017
    Copy the full SHA
    809c407 View commit details
  2. Add param type

    To fix error in CI
    yubaoquan committed Oct 10, 2017
    Copy the full SHA
    1865f5b View commit details
  3. Add props declaration of FixButton

    To fix CI error
    yubaoquan committed Oct 10, 2017
    Copy the full SHA
    bea0e08 View commit details
  4. Merge pull request #447 from yubaoquan/feature_fix_button

    Add feature
    Steel Brain authored Oct 10, 2017
    Copy the full SHA
    022d0c9 View commit details
  5. 🎨 Minor changes to recently merged PR

    Steel Brain committed Oct 10, 2017
    Copy the full SHA
    9e77e90 View commit details
  6. 📝 Document change in CHANGELOG

    Steel Brain committed Oct 10, 2017
    Copy the full SHA
    afc0207 View commit details
  7. 🐛 Make flow happy

    Steel Brain committed Oct 10, 2017
    Copy the full SHA
    f93b38c View commit details

Commits on Jan 8, 2018

  1. ⬆️ Upgrade marked to latest version

    Steel Brain committed Jan 8, 2018
    Copy the full SHA
    6d319f0 View commit details
  2. 📝 Document version in CHANGELOG

    Steel Brain committed Jan 8, 2018
    Copy the full SHA
    ad42a1b View commit details
  3. Prepare 1.6.11 release

    Steel Brain committed Jan 8, 2018
    Copy the full SHA
    8173c24 View commit details

Commits on Jan 24, 2018

  1. Copy the full SHA
    561d0a0 View commit details
  2. Update linter-ui.less

    szhu authored Jan 24, 2018
    Copy the full SHA
    6712734 View commit details

Commits on Feb 1, 2018

  1. Merge pull request #467 from szhu/patch-1

    Set max-width for linter tooltip for readability.
    Steel Brain authored Feb 1, 2018
    Copy the full SHA
    04666f0 View commit details
  2. 📝 Document change in CHANGELOG

    Steel Brain committed Feb 1, 2018
    Copy the full SHA
    6327978 View commit details
  3. Prepare 1.6.12 release

    Steel Brain committed Feb 1, 2018
    Copy the full SHA
    8a98908 View commit details
  4. Revert "Prepare 1.6.12 release"

    Was never published to APM. Also APM sucks :(
    This reverts commit 8a98908.
    Steel Brain committed Feb 1, 2018
    Copy the full SHA
    6f8c1d3 View commit details

Commits on Feb 2, 2018

  1. Copy the full SHA
    e28c015 View commit details
  2. chore(package): update package-lock.json

    Update the `package-lock.json` file to the current install state.
    Arcanemagus committed Feb 2, 2018
    Copy the full SHA
    3be9cdc View commit details
  3. chore(lint): fix linting errors

    Fix the linting errors introduced with the new configuration.
    
    Also disables `eslint-plugin-jsx-a11y` from being checked by Flow.
    Arcanemagus committed Feb 2, 2018
    Copy the full SHA
    5cafb38 View commit details
  4. Merge pull request #472 from steelbrain/greenkeeper/eslint-config-ste…

    …elbrain-4.0.1
    
    chore(package): update eslint-config-steelbrain to version 4.0.1
    Arcanemagus authored Feb 2, 2018
    Copy the full SHA
    513258e View commit details
  5. Copy the full SHA
    6168415 View commit details
  6. chore(package): update package-lock.json

    Update the `package-lock.json` file to match the changes to
    `package.json`.
    Arcanemagus committed Feb 2, 2018
    Copy the full SHA
    d8901e9 View commit details
  7. chore(lint): fix lint issues

    Fix the new Flow issues exposed by the updated version. Mostly this just
    entailed adding explicit types to the `React.Component` inheritance.
    Arcanemagus committed Feb 2, 2018
    Copy the full SHA
    d798364 View commit details
  8. Merge pull request #474 from steelbrain/arcanemagus/flow-bin-0.64.0

    Update flow-bin to version 0.64.0
    Arcanemagus authored Feb 2, 2018
    Copy the full SHA
    5d29d04 View commit details

Commits on Feb 4, 2018

  1. 🎨 Move common logic into a helper function

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    5694f14 View commit details
  2. 🆕 Add alwaysTakeMinimumSpace config

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    bdb70af View commit details
  3. 🆕 Make alwaysTakeMinimumHeight work

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    ed94be2 View commit details
  4. 🆕 Remember resizes

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    bb8aacd View commit details
  5. 📝 Document change in CHANGELOG

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    d288ae2 View commit details
  6. 🐛 WHOOPS forgot this

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    d2bffc0 View commit details
  7. 🐛 Fix a condition

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    4a4de3d View commit details
  8. 🎨 Address review

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    f5d5b92 View commit details
  9. Merge pull request #444 from steelbrain/greenkeeper/react-dom-16.0.0

    Update react-dom to the latest version 🚀
    Steel Brain authored Feb 4, 2018
    Copy the full SHA
    7b411af View commit details
  10. fix(package): update react to version 16.0.0

    greenkeeper[bot] authored and Steel Brain committed Feb 4, 2018
    Copy the full SHA
    22acfc9 View commit details
  11. Merge pull request #443 from steelbrain/greenkeeper/react-16.0.0

    Update react to the latest version 🚀
    Steel Brain authored Feb 4, 2018
    Copy the full SHA
    fb8f72d View commit details
  12. ⬆️ Upgrade package-lock (no actual changes)

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    24bdae3 View commit details
  13. ⬆️ Upgrade sb-react-table to fix peer dep warning

    Steel Brain committed Feb 4, 2018
    Copy the full SHA
    ce03a14 View commit details

Commits on Feb 5, 2018

  1. 🎨 Fix a typo?

    Steel Brain committed Feb 5, 2018
    Copy the full SHA
    3bc1b14 View commit details
  2. 🐛 Fix behavior where changing config doesn't work

    Steel Brain committed Feb 5, 2018
    Copy the full SHA
    4f200c0 View commit details

Commits on Feb 7, 2018

  1. chore(package): update flow-bin to version 0.65.0 (#477)

    Update flow-bin to version 0.65.0 🚀
    greenkeeper[bot] authored and Arcanemagus committed Feb 7, 2018
    Copy the full SHA
    dca54d5 View commit details

Commits on Feb 16, 2018

  1. Copy the full SHA
    51add39 View commit details

Commits on Feb 18, 2018

  1. Copy the full SHA
    de797d0 View commit details

Commits on Mar 1, 2018

  1. Merge pull request #475 from steelbrain/steelbrain/dock-take-minimum-…

    …space
    
    Add alwaysTakeMinimumSpace to new dock panel
    Steel Brain authored Mar 1, 2018
    Copy the full SHA
    fd73ea6 View commit details
  2. ⬆️ Upgrade eslint config and use prettier

    Steel Brain committed Mar 1, 2018
    Copy the full SHA
    4fa583c View commit details
  3. 🆕 Add prettier to tests

    Steel Brain committed Mar 1, 2018
    Copy the full SHA
    573da12 View commit details
  4. Merge remote-tracking branch 'origin/master' into greenkeeper/eslint-…

    …config-steelbrain-5.0.0
    Steel Brain committed Mar 1, 2018
    Copy the full SHA
    5fca6b2 View commit details
Showing with 16,173 additions and 4,494 deletions.
  1. +0 −1 .eslintignore
  2. +5 −7 .eslintrc.json
  3. +0 −13 .flowconfig
  4. +6 −0 .gitattributes
  5. +110 −0 .github/workflows/CI.yml
  6. +14 −0 .gitignore
  7. +4 −0 .npmrc
  8. +9 −0 .prettierignore
  9. +1 −0 .terserrc.js
  10. +300 −64 CHANGELOG.md
  11. +52 −52 CONTRIBUTING.md
  12. +18 −5 README.md
  13. +3 −0 babel.config.json
  14. +14 −0 babel.unit.config.json
  15. +142 −0 benchmark/benchmark.js
  16. +0 −19 circle.yml
  17. +0 −25 decls/atom.js
  18. +0 −11 decls/jasmine.js
  19. +23 −0 dist/busy-signal.d.ts
  20. +11 −0 dist/commands.d.ts
  21. +14 −0 dist/editor/helpers.d.ts
  22. +44 −0 dist/editor/index.d.ts
  23. +21 −0 dist/editors.d.ts
  24. +45 −0 dist/helpers.d.ts
  25. +10 −0 dist/index.d.ts
  26. +2 −0 dist/index.js
  27. +1 −0 dist/index.js.map
  28. +11 −0 dist/intentions.d.ts
  29. +27 −0 dist/main.d.ts
  30. +2 −0 dist/marked.esm.ab6d9469.js
  31. +1 −0 dist/marked.esm.ab6d9469.js.map
  32. +6 −0 dist/panel/component.d.ts
  33. +16 −0 dist/panel/delegate.d.ts
  34. +25 −0 dist/panel/dock.d.ts
  35. +22 −0 dist/panel/index.d.ts
  36. +17 −0 dist/status-bar/element.d.ts
  37. +1 −0 dist/status-bar/helpers.d.ts
  38. +15 −0 dist/status-bar/index.d.ts
  39. +13 −0 dist/tooltip/delegate.d.ts
  40. +16 −0 dist/tooltip/index.d.ts
  41. +9 −0 dist/tooltip/message.d.ts
  42. +3 −0 dist/tree-view/helpers.d.ts
  43. +19 −0 dist/tree-view/index.d.ts
  44. +3,446 −0 dist/tsconfig.tsbuildinfo
  45. +22 −0 dist/types/atom.d.ts
  46. +3 −0 dist/types/index.d.ts
  47. +20 −0 dist/types/intentions.d.ts
  48. +1 −0 dist/types/linter.d.ts
  49. +30 −30 lib/{busy-signal.js → busy-signal.ts}
  50. +0 −132 lib/commands.js
  51. +132 −0 lib/commands.ts
  52. +0 −69 lib/editor/helpers.js
  53. +77 −0 lib/editor/helpers.ts
  54. +0 −317 lib/editor/index.js
  55. +367 −0 lib/editor/index.ts
  56. +0 −90 lib/editors.js
  57. +139 −0 lib/editors.ts
  58. +6 −0 lib/electron.d.ts
  59. +0 −218 lib/helpers.js
  60. +279 −0 lib/helpers.ts
  61. +0 −60 lib/index.js
  62. +77 −0 lib/index.ts
  63. +0 −53 lib/intentions.js
  64. +48 −0 lib/intentions.ts
  65. +0 −112 lib/main.js
  66. +108 −0 lib/main.ts
  67. +0 −98 lib/panel/component.js
  68. +84 −0 lib/panel/component.tsx
  69. +0 −89 lib/panel/delegate.js
  70. +91 −0 lib/panel/delegate.ts
  71. +0 −66 lib/panel/dock.js
  72. +126 −0 lib/panel/dock.tsx
  73. +0 −102 lib/panel/index.js
  74. +159 −0 lib/panel/index.ts
  75. +18 −27 lib/status-bar/{element.js → element.ts}
  76. +0 −15 lib/status-bar/helpers.js
  77. +9 −0 lib/status-bar/helpers.ts
  78. +0 −107 lib/status-bar/index.js
  79. +112 −0 lib/status-bar/index.ts
  80. +0 −63 lib/tooltip/delegate.js
  81. +67 −0 lib/tooltip/delegate.ts
  82. +0 −67 lib/tooltip/index.js
  83. +101 −0 lib/tooltip/index.tsx
  84. +0 −79 lib/tooltip/message-legacy.js
  85. +0 −131 lib/tooltip/message.js
  86. +167 −0 lib/tooltip/message.tsx
  87. +17 −14 lib/tree-view/{helpers.js → helpers.ts}
  88. +0 −131 lib/tree-view/index.js
  89. +141 −0 lib/tree-view/index.ts
  90. +38 −0 lib/tsconfig.json
  91. +0 −89 lib/types.js
  92. +22 −0 lib/types/atom.d.ts
  93. +3 −0 lib/types/index.d.ts
  94. +20 −0 lib/types/intentions.d.ts
  95. +1 −0 lib/types/linter.d.ts
  96. +0 −2,017 package-lock.json
  97. +104 −17 package.json
  98. +8,791 −0 pnpm-lock.yaml
  99. +8 −0 prettier.config.js
  100. +31 −0 scripts/get-linter-types.js
  101. +0 −5 spec/.eslintrc.json
  102. +32 −0 spec/activate.spec.js
  103. +14 −9 spec/busy-singal-spec.js
  104. +40 −21 spec/editor-spec.js
  105. +8 −0 spec/fixtures/.eslintrc.json
  106. +3 −0 spec/fixtures/error.ts
  107. +4 −0 spec/fixtures/expandable-description.rb
  108. +2 −0 spec/fixtures/info.ts
  109. +14 −0 spec/fixtures/long-text.ts
  110. +3 −0 spec/fixtures/tsconfig.json
  111. +3 −0 spec/fixtures/warning.ts
  112. +2 −0 spec/fixtures/with-fixes.ts
  113. +9 −7 spec/helpers.js
  114. BIN spec/very-large-file.zip
  115. +31 −16 styles/bottom-panel.less
  116. +91 −46 styles/linter-ui.less
1 change: 0 additions & 1 deletion .eslintignore

This file was deleted.

12 changes: 5 additions & 7 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
{
"extends": "steelbrain",
"extends": "eslint-config-atomic/react",
"ignorePatterns": ["dist/", "node_modules/", "spec/fixtures", "lib/types/linter/"],
"rules": {
"no-param-reassign": "off",
"no-duplicate-imports": "off",
"no-underscore-dangle": "off",
"react/no-danger": "off",
"react/no-danger-with-children": "off",
"global-require": "off"
"@typescript-eslint/no-inferrable-types": "off",
"@typescript-eslint/no-non-null-assertion": "off",
"react/react-in-jsx-scope": "off"
}
}
13 changes: 0 additions & 13 deletions .flowconfig

This file was deleted.

6 changes: 6 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
* text=auto

# don't diff machine generated files
dist/ -diff
package-lock.json -diff
pnpm-lock.yaml -diff
110 changes: 110 additions & 0 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
name: CI
on:
pull_request:
push:
branches:
- master

jobs:
Test:
if: "!contains(github.event.head_commit.message, '[skip ci]')"
name: ${{ matrix.os }} - Atom ${{ matrix.atom_channel }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
- macos-latest
- windows-latest
atom_channel: [stable, beta]
steps:
- uses: actions/checkout@v2
- name: Cache
id: node_modules
uses: actions/cache@v2
with:
path: |
node_modules
key: ${{ runner.os }}-node-${{ hashFiles('**/package.json') }}

- uses: UziTech/action-setup-atom@v1
with:
channel: ${{ matrix.atom_channel }}
- name: Versions
run: apm -v

- uses: pnpm/action-setup@v2.2.2
with:
version: 6

- uses: actions/setup-node@v3
with:
node-version: 12.x

- name: Install dependencies
run: pnpm i

- name: Run tests 👩🏾‍💻
run: pnpm run test

- name: Run benchmarks
run: pnpm run benchmark

Lint:
if: "!contains(github.event.head_commit.message, '[skip ci]')"
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- if: "!contains(github.event.head_commit.message, 'Prepare')"
name: Commit lint ✨
uses: wagoid/commitlint-github-action@v2

- uses: pnpm/action-setup@v2
with:
version: 6

- name: Install dependencies
run: pnpm install

- name: Format ✨
run: pnpm run test.format

- name: Lint ✨
run: pnpm run test.lint

# Release:
# needs: [Test, Lint]
# if: github.ref == 'refs/heads/master' &&
# github.event.repository.fork == false
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v2
# - uses: UziTech/action-setup-atom@v1
# - uses: actions/setup-node@v1
# with:
# node-version: '12.x'
# - name: NPM install
# run: npm install
# - name: Build and Commit.
# run: npm run build-commit
# NOTE: uncomment when ready
# - name: Release 🎉
# uses: cycjimmy/semantic-release-action@v2
# with:
# extends: |
# @semantic-release/apm-config
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# ATOM_ACCESS_TOKEN: ${{ secrets.ATOM_ACCESS_TOKEN }}

Skip:
if: contains(github.event.head_commit.message, '[skip ci]')
runs-on: ubuntu-latest
steps:
- name: Skip CI 🚫
run: echo skip ci
14 changes: 14 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
# OS metadata
.DS_Store
npm-debug.log
Thumbs.db

# Node
node_modules
.idea
package-lock.json

# TypeScript
*.tsbuildinfo

# Build directories
dist
.parcel-cache
benchmarkTestFile.*
lib/types/linter
4 changes: 4 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
public-hoist-pattern[]=*
package-lock=false
lockfile=true
prefer-frozen-lockfile=true
9 changes: 9 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
node_modules
package.json
package-lock.json
pnpm-lock.yaml
coverage
build
dist
spec/fixtures
lib/types/linter
1 change: 1 addition & 0 deletions .terserrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = require('terser-config-atomic')
Loading