Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding / Profile - Proactively ask user to update profile #21571

Open
ilmotta opened this issue Nov 5, 2024 · 4 comments · May be fixed by #21862
Open

Onboarding / Profile - Proactively ask user to update profile #21571

ilmotta opened this issue Nov 5, 2024 · 4 comments · May be fixed by #21862
Assignees
Labels
Milestone

Comments

@ilmotta
Copy link
Contributor

ilmotta commented Nov 5, 2024

Feature

Description

Now that we are simplifying the onboarding journey, the user will have a default display name based on their compressed key, as well as a default random accent color (see issue #21567).

Before the user sends a contact request or send a message to somebody, we should ask the user if they want to update their profile.

Acceptance criteria

  • We ask only once if the user wants to update their profile. Use async storage because this choice doesn't need to be persisted in status-go.
  • We ask the user right before pressing on Send contact request and right after pressing on the + button in the Messages home screen.
  • Once the user finishes editing their profile, they should be automatically redirected to their original intent (either send contact request or open bottom sheet to add contact/new chat)

Resources

@Parveshdhull
Copy link
Member

required for #21567

@ulisesmac ulisesmac self-assigned this Nov 19, 2024
@churik churik modified the milestones: 2.32.0, 2.33.0 Nov 27, 2024
@churik
Copy link
Member

churik commented Nov 27, 2024

is moved to 2.33 due to limited capacity - but it is better to make it with #21567

@ilmotta
Copy link
Contributor Author

ilmotta commented Nov 27, 2024

Confirmed with Volo that this issue 21571 is not a requirement for 2.32 because users will still be able to edit all their profile data after onboarding. On the other hand, issue #21567 is a must have for 2.32.

Given this plan @ulisesmac, the best is to completely ignore this issue (21571) and focus on #21567. Only once #21567 is merged we should come back to #21571.

@ulisesmac
Copy link
Contributor

Sure! @ilmotta

@ulisesmac ulisesmac linked a pull request Dec 20, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants