Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🖇️ Integrate Keycard signing flow for dapp transactions #21618

Open
2 tasks
Tracked by #21579
shivekkhurana opened this issue Nov 13, 2024 · 0 comments · May be fixed by #21785
Open
2 tasks
Tracked by #21579

🖇️ Integrate Keycard signing flow for dapp transactions #21618

shivekkhurana opened this issue Nov 13, 2024 · 0 comments · May be fixed by #21785
Assignees
@clauxx
Labels
feature feature requests wallet-core Issues for mobile wallet team
Milestone
2.33.0

Comments

@shivekkhurana
Copy link
Contributor

Feature Issue

User Story

As a Keycard user,
I want to be able to sign smart contract txns using my Keycard
so that I can call myself a cool kid and my ETH stays secure, .

Description

If the account being used to sign a dapp txn is a Keycard account, the flow should change as per the designs.

Figma: https://www.figma.com/design/YGm3igIOAcwMqUVJWCJ6f1/Keycard-UX?node-id=409-58818&t=VFIzh8BRInCRKpP9-1

Acceptance Criteria

  • A Keycard account should see "Sign with Keycard" message and Keycard logo when trying to sign a dapp txn
  • User should be able to complete txn signing with Keycard

Notes

2.32 milestone is aggressive. There is no stress if we are not able to get this in.
@shivekkhurana shivekkhurana added the feature feature requests label Nov 13, 2024
@shivekkhurana shivekkhurana added this to the 2.32.0 milestone Nov 13, 2024
@shivekkhurana shivekkhurana changed the title 🖇️ Integrate keycard signing flow for dapp transactions 🖇️ Integrate Keycard signing flow for dapp transactions Nov 13, 2024
@clauxx clauxx moved this to In Progress in Status Desktop/Mobile Board Nov 19, 2024
@flexsurfer flexsurfer mentioned this issue Nov 28, 2024
Closed
@churik churik added the wallet-core Issues for mobile wallet team label Dec 2, 2024
@churik churik modified the milestones: 2.32.0, 2.33.0 Dec 2, 2024
@flexsurfer flexsurfer mentioned this issue Dec 9, 2024
Open
7 tasks
@clauxx clauxx linked a pull request Dec 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clauxx clauxx

Labels
feature feature requests wallet-core Issues for mobile wallet team
Projects
Status Desktop/Mobile Board
Status: In Progress
Milestone
2.33.0
Development

Successfully merging a pull request may close this issue.

Keycard signing for dapp interactions status-im/status-mobile
3 participants
@shivekkhurana @churik @clauxx