Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange private chat content after restoring from seed phrase #15849

Open
endulab opened this issue Jul 29, 2024 · 1 comment · May be fixed by status-im/status-go#6184
Open

Strange private chat content after restoring from seed phrase #15849

endulab opened this issue Jul 29, 2024 · 1 comment · May be fixed by status-im/status-go#6184
Assignees
@jrainville
Labels
2-30-bug-bash bug Something isn't working core-team Desktop Contact Requests
Milestone
2.33.0 Beta

Comments

@endulab
Copy link
Contributor

endulab commented Jul 29, 2024

Bug Report

Description

After successful account restoring, in every private chat there was a message sent from me: "Please add me to your contacts" with incorrect date: 1.01.1970. This message was not seen by another user.

image

Steps to reproduce

Have a private chat with another account.
Restore account from seed phrase.
Restoring completed successfully.
Go to private chat and check content.

Additional Information

  • Status desktop version: release/2.30.x
  • Operating System: macosx

NOTE
This issue was also mentioned in #14052
@endulab endulab added bug Something isn't working backend-team 2-30-bug-bash labels Jul 29, 2024
@endulab endulab added this to the 2.30.0 Beta milestone Jul 29, 2024
@endulab endulab changed the title Strange chat content after restoring from seed phrase Strange private chat content after restoring from seed phrase Jul 29, 2024
@jrainville jrainville moved this to Iteration Backlog in Status Desktop/Mobile Board Jul 29, 2024
@MishkaRogachev
Copy link
Contributor

it's because we're not rebuilding contact requests, we're rebuilding the contacts themselves. And we create a fake contact request. I can just remove it from chat and notifications.

@iurimatias iurimatias modified the milestones: 2.30.0 Beta, 2.31.0 Beta Aug 5, 2024
@jrainville jrainville modified the milestones: 2.31.0 Beta, 2.32.0 Beta Aug 26, 2024
@jrainville jrainville modified the milestones: 2.32.0 Beta, 2.33.0 Beta Dec 3, 2024
@jrainville jrainville mentioned this issue Dec 9, 2024
Closed
@jrainville jrainville self-assigned this Dec 9, 2024
@jrainville jrainville moved this to In Progress in Status Desktop/Mobile Board Dec 9, 2024
jrainville added a commit to status-im/status-go that referenced this issue Dec 9, 2024
@jrainville
fix(backup)_: dont generate a CR if the synced contact is mutual
814e375 
Fixes status-im/status-desktop#15849

The problem was that we generated a "fake" contact request for all synced contacts.
While it's true that even mutual contacts have a contact request, we don't need it anymore once mutual and since we don't sync messages, we had to generate it with a default message and that message looked very out of place after a recovery.
@jrainville jrainville linked a pull request Dec 9, 2024 that will close this issue
Open
jrainville added a commit to status-im/status-go that referenced this issue Dec 9, 2024
@jrainville
fix(backup)_: dont generate a CR if the synced contact is mutual
029ea03 
Fixes status-im/status-desktop#15849

The problem was that we generated a "fake" contact request for all synced contacts.
While it's true that even mutual contacts have a contact request, we don't need it anymore once mutual and since we don't sync messages, we had to generate it with a default message and that message looked very out of place after a recovery.
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Dec 9, 2024
jrainville added a commit to status-im/status-go that referenced this issue Dec 12, 2024
@jrainville
fix(backup)_: dont generate a CR if the synced contact is mutual
4187ae9 
Fixes status-im/status-desktop#15849

The problem was that we generated a "fake" contact request for all synced contacts.
While it's true that even mutual contacts have a contact request, we don't need it anymore once mutual and since we don't sync messages, we had to generate it with a default message and that message looked very out of place after a recovery.
jrainville added a commit to status-im/status-go that referenced this issue Dec 13, 2024
@jrainville
fix(backup)_: dont generate a CR if the synced contact is mutual
a417efe 
Fixes status-im/status-desktop#15849

The problem was that we generated a "fake" contact request for all synced contacts.
While it's true that even mutual contacts have a contact request, we don't need it anymore once mutual and since we don't sync messages, we had to generate it with a default message and that message looked very out of place after a recovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
2-30-bug-bash bug Something isn't working core-team Desktop Contact Requests
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

fix(backup)_: dont generate a CR if the synced contact is mutual status-im/status-go
5 participants
@iurimatias @MishkaRogachev @caybro @jrainville @endulab