Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy implementation in httpclient #193

Open
zer0pwned opened this issue May 23, 2021 · 2 comments
Open

proxy implementation in httpclient #193

zer0pwned opened this issue May 23, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@zer0pwned
Copy link

First of all, thank you guys so much for putting effort this amazing project. I really enjoy using it and learning how to make the NIM project clean and organized. I was wondering, does the httpclient support regular http/https proxy, just like NIM std httpclient library? I went through the code and I didn't find code can realize this functionality but just want to make sure.

If not I think it should be easy to implement and I can try to do that then make PR. The only thing worries me that is you have very well defined test cases and I don't have anything on top of my head how to make a robust test case for the http proxy (mainly to find a long lifetime public proxy server).

@arnetheduck
Copy link
Member

Indeed. The way to write a test case would be to implement a small proxy server in the test case and validate through there that the client is sending the proper content (and consequently getting the right responses) - one way to get examples is to record a proxy session with wireshark for example.

@zer0pwned
Copy link
Author

zer0pwned commented May 28, 2021

That's a great idea! Thank you for the suggestion! Apparently cheatfate is the main contributor of the httpclient code. Not sure if he is already implementing this part but will start to work on this on my side anyway. : )

@cheatfate cheatfate added the enhancement New feature or request label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants