Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit code flow for certain Whisper IDs #79

Open
rachelhamlin opened this issue Oct 29, 2018 · 1 comment
Open

Fix edit code flow for certain Whisper IDs #79

rachelhamlin opened this issue Oct 29, 2018 · 1 comment
Assignees

Comments

@rachelhamlin
Copy link

rachelhamlin commented Oct 29, 2018

It appears that an issue on status-go side is making it impossible for certain users to edit their contact code.

Contact codes are possibly being incorrectly generated.

@bgits
Copy link
Contributor

bgits commented Oct 29, 2018

I think this contract code is not properly generated: 0x04beb846a66a820bf7c2ecee595ce9cf7850ac3449029639e93462815c7391868402e0998c5e3bd6cf35769d74a06400811c100404ae70ee3e2ca796b7949fd4de - when trying to extract the x,y coordinates the y coordinate is shorter than the x. As a result this address will not be able to register their contact code.

It's also possible we are not properly extracting the XY coordinates on the client side, but would need to confirm this with someone. Not sure who is involved with the contact code generation process in the Status client.

function for extracting X,Y points from pubKey here: https://github.com/status-im/ens-usernames/blob/invalid-names-handling/app/utils/ecdsa.js#L5

@rachelhamlin rachelhamlin changed the title [Draft] Fix edit code flow for certain Whisper IDs Fix edit code flow for certain Whisper IDs Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants