Consider phasing out noop keybinding if underlying issues were indeed fixed

[sourishkrout]

Bring back the default set of keyboard shortcuts.

vscode-runme/package.json

Lines 934 to 1013 in 4cda7c3

	{
	"command": "runme.keybinding.noop",
	"key": "m",
	"when": "notebookEditorFocused && !inputFocus && activeEditor == 'workbench.editor.notebook' && notebookCellType == 'code'"
	},
	{
	"command": "runme.keybinding.noop",
	"key": "y",
	"when": "notebookEditorFocused && !inputFocus && activeEditor == 'workbench.editor.notebook' && notebookCellType == 'markup'"
	},
	{
	"key": "F",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "K",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "J",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "A",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "B",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "D D",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "Z",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "S",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "C",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "X",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "V",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "shift+L",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "O",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	},
	{
	"key": "L",
	"when": "notebookEditorFocused && !inputFocus && !notebookOutputInputFocused",
	"command": "runme.keybinding.noop"
	}

[jlewi]

Is there a link to the original adverse effects? Were you using the same keybindings normally used by vscode notebooks?

[sourishkrout]

Is there a link to the original adverse effects? Were you using the same keybindings normally used by vscode notebooks?

I'm gonna have to go dig a bit. don't know off hand. i believe we have some records of what didn't work in issues/PRs. i'll post them here.