From a52fac61c9528b6a4ee6942ba7c34a8b7e8c625f Mon Sep 17 00:00:00 2001 From: Sebastian Tiedtke Date: Tue, 17 Sep 2024 13:54:04 -0700 Subject: [PATCH] Allow multiple args --- internal/runner/command.go | 2 +- internal/runner/command_test.go | 29 +++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/internal/runner/command.go b/internal/runner/command.go index 62762dd7..c0ca18d3 100644 --- a/internal/runner/command.go +++ b/internal/runner/command.go @@ -668,7 +668,7 @@ func parseFileProgram(programPath string) (program string, args []string) { } if len(parts) > 1 { - args = []string{parts[1]} + args = strings.Split(parts[1], " ") } return diff --git a/internal/runner/command_test.go b/internal/runner/command_test.go index e5cdfad3..7b641267 100644 --- a/internal/runner/command_test.go +++ b/internal/runner/command_test.go @@ -168,6 +168,35 @@ func Test_command(t *testing.T) { assert.Equal(t, "", string(data)) }) + t.Run("DenoWithArgs", func(t *testing.T) { + t.Parallel() + + stdout := new(bytes.Buffer) + stderr := new(bytes.Buffer) + + cmd, err := newCommand( + context.Background(), + &commandConfig{ + ProgramName: "deno run --allow-all", + LanguageID: "ts", + Stdout: stdout, + Stderr: stderr, + CommandMode: CommandModeTempFile, + Script: "console.log('1'); console.log('2')", + Logger: testCreateLogger(t), + }, + ) + require.NoError(t, err) + require.NoError(t, cmd.Start(context.Background())) + require.NoError(t, cmd.Wait()) + data, err := io.ReadAll(stdout) + assert.NoError(t, err) + assert.Equal(t, "1\n2\n", string(data)) + data, err = io.ReadAll(stderr) + assert.NoError(t, err) + assert.Equal(t, "", string(data)) + }) + t.Run("Nonexec resorts to cat", func(t *testing.T) { t.Parallel()