From a83eeba31a946d121a6fabccd647c05515d98c11 Mon Sep 17 00:00:00 2001 From: Philippe SWARTVAGHER Date: Tue, 6 Aug 2024 15:09:00 +0200 Subject: [PATCH] Add TODO about updating the priority of cached MPI communications --- mpi/src/starpu_mpi_task_insert.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/mpi/src/starpu_mpi_task_insert.c b/mpi/src/starpu_mpi_task_insert.c index ba822e707f..18802bbab5 100644 --- a/mpi/src/starpu_mpi_task_insert.c +++ b/mpi/src/starpu_mpi_task_insert.c @@ -159,7 +159,18 @@ int _starpu_mpi_exchange_data_before_execution(starpu_data_handle_t data, enum s _STARPU_MPI_DEBUG(1, "Sending data %p to %d with prio %d\n", data, xrank, prio); _SEND_DATA(data, mode, xrank, data_tag, prio, comm, NULL, NULL); } - // Else the data has already been sent + /* Else the data has already been sent + * + * TODO: if the cached communication did not start yet, and if + * the priority of the ignored communication is higher than the + * cached communication, change the priority of the cached + * communication to reflect it is actually needed with a higher + * priority. + * In StarPU-MPI this can be done while the request is in the + * ready_send_requests list and before its MPI_Isend is issued; + * with StarPU-NewMadeleine, it requires explicit support from + * NewMadeleine (management of list of send requests is done + * directly by NewMadeleine). */ } } return 0;