From 2b66f6aaa6488092a84f967edc4c614220642b07 Mon Sep 17 00:00:00 2001
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Wed, 25 Sep 2024 10:53:05 +0200
Subject: [PATCH] cholesky: Fix priority of syrks

According to the Chameleon priorities. We indeed need to prioritize
syrks which are on the critical path. That's a bit approximative since
the gemms around will also pose a priority problem, but better keep
coherent with Chameleon.
---
 examples/cholesky/cholesky_implicit.c                     | 7 ++++++-
 mpi/examples/matrix_decomposition/mpi_cholesky_codelets.c | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/examples/cholesky/cholesky_implicit.c b/examples/cholesky/cholesky_implicit.c
index 45c3e90efd..3ced7645f2 100644
--- a/examples/cholesky/cholesky_implicit.c
+++ b/examples/cholesky/cholesky_implicit.c
@@ -182,7 +182,12 @@ static int gemm_priority(unsigned nblocks, unsigned k, unsigned m, unsigned n, d
 	}
 
 	if (priority_attribution_p == 0) /* Base priority */
-		return 2*nblocks - 2*k - m - n;
+	{
+		if (n == m)
+			return 2*nblocks - 2*k - n;
+		else
+			return 2*nblocks - 2*k - m - n;
+	}
 
 	if (priority_attribution_p == 1)
 		return 3*nblocks - (k + n + m);
diff --git a/mpi/examples/matrix_decomposition/mpi_cholesky_codelets.c b/mpi/examples/matrix_decomposition/mpi_cholesky_codelets.c
index 14cec820c7..9459b199c0 100644
--- a/mpi/examples/matrix_decomposition/mpi_cholesky_codelets.c
+++ b/mpi/examples/matrix_decomposition/mpi_cholesky_codelets.c
@@ -199,7 +199,7 @@ static void run_cholesky(starpu_data_handle_t **data_handles, int rank, int node
 		for (n = k+1; n<nblocks; n++)
 		{
 			starpu_mpi_task_insert(MPI_COMM_WORLD, &cl_syrk,
-					       STARPU_PRIORITY, noprio ? STARPU_DEFAULT_PRIO : unbound_prio ? (int)(2*nblocks - 2*k - n - n) : (n == k+1)?STARPU_MAX_PRIO:STARPU_DEFAULT_PRIO,
+					       STARPU_PRIORITY, noprio ? STARPU_DEFAULT_PRIO : unbound_prio ? (int)(2*nblocks - 2*k - n) : (n == k+1)?STARPU_MAX_PRIO:STARPU_DEFAULT_PRIO,
 					       STARPU_R, data_handles[n][k],
 					       STARPU_RW | STARPU_COMMUTE, data_handles[n][n],
 					       STARPU_FLOPS, (double) FLOPS_SSYRK(nn, nn),