From c03c19c6ae836dfce027191834f066c6bd641a49 Mon Sep 17 00:00:00 2001 From: Alon Lukatch Date: Sun, 22 Dec 2024 15:32:23 +0200 Subject: [PATCH] chore: fix CR comments --- crates/starknet_state_sync/src/runner/mod.rs | 2 +- crates/starknet_state_sync/src/runner/test.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/starknet_state_sync/src/runner/mod.rs b/crates/starknet_state_sync/src/runner/mod.rs index edb6371fa8..33b4404b0e 100644 --- a/crates/starknet_state_sync/src/runner/mod.rs +++ b/crates/starknet_state_sync/src/runner/mod.rs @@ -34,7 +34,7 @@ impl ComponentStarter for StateSyncRunner { } result = &mut self.p2p_sync_client_future => return result.map_err(|_| ComponentError::InternalComponentError), () = &mut self.p2p_sync_server_future => { - return Err(ComponentError::InternalComponentError); + return Ok(()); } } } diff --git a/crates/starknet_state_sync/src/runner/test.rs b/crates/starknet_state_sync/src/runner/test.rs index f1ba2e47d9..bc044fa550 100644 --- a/crates/starknet_state_sync/src/runner/test.rs +++ b/crates/starknet_state_sync/src/runner/test.rs @@ -27,13 +27,13 @@ fn run_returns_when_sync_client_future_returns() { } #[test] -fn run_returns_error_when_sync_server_future_returns() { +fn run_returns_when_sync_server_future_returns() { let network_future = pending().boxed(); let p2p_sync_client_future = pending().boxed(); let p2p_sync_server_future = ready(()).boxed(); let mut state_sync_runner = StateSyncRunner { network_future, p2p_sync_client_future, p2p_sync_server_future }; - state_sync_runner.start().now_or_never().unwrap().unwrap_err(); + state_sync_runner.start().now_or_never().unwrap().unwrap(); } #[test]