From 78bb277aca68f80709d7499d465d736a6ce4e370 Mon Sep 17 00:00:00 2001 From: Guy Nir Date: Sun, 15 Dec 2024 14:57:54 +0200 Subject: [PATCH] chore(consensus): remove irrelevant TODO items --- crates/papyrus_protobuf/Cargo.toml | 1 - crates/papyrus_protobuf/src/consensus.rs | 1 - crates/sequencing/papyrus_consensus/src/manager_test.rs | 4 ---- 3 files changed, 6 deletions(-) diff --git a/crates/papyrus_protobuf/Cargo.toml b/crates/papyrus_protobuf/Cargo.toml index 1fe9091503c..5d638b27568 100644 --- a/crates/papyrus_protobuf/Cargo.toml +++ b/crates/papyrus_protobuf/Cargo.toml @@ -9,7 +9,6 @@ license-file.workspace = true testing = ["papyrus_test_utils", "rand", "rand_chacha"] [dependencies] -# TODO(Guy): Remove after implementing broadcast streams. indexmap.workspace = true lazy_static.workspace = true primitive-types.workspace = true diff --git a/crates/papyrus_protobuf/src/consensus.rs b/crates/papyrus_protobuf/src/consensus.rs index 576e4781068..257b5ef66f2 100644 --- a/crates/papyrus_protobuf/src/consensus.rs +++ b/crates/papyrus_protobuf/src/consensus.rs @@ -116,7 +116,6 @@ where T: Clone + Into> + TryFrom, Error = ProtobufConversionError>, { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { - // TODO(guyn): add option to display when message is Fin and doesn't have content (PR #1048) if let StreamMessageBody::Content(message) = &self.message { let message: Vec = message.clone().into(); write!( diff --git a/crates/sequencing/papyrus_consensus/src/manager_test.rs b/crates/sequencing/papyrus_consensus/src/manager_test.rs index ea49229ab15..6fbaeff15ac 100644 --- a/crates/sequencing/papyrus_consensus/src/manager_test.rs +++ b/crates/sequencing/papyrus_consensus/src/manager_test.rs @@ -83,7 +83,6 @@ async fn manager_multiple_heights_unordered() { mock_register_broadcast_topic().unwrap(); let mut sender = mock_network.broadcasted_messages_sender; - // TODO(guyn): refactor this test to pass proposals through the correct channels. let (mut proposal_receiver_sender, mut proposal_receiver_receiver) = mpsc::channel(CHANNEL_SIZE); @@ -149,7 +148,6 @@ async fn run_consensus_sync() { let mut context = MockTestContext::new(); let (decision_tx, decision_rx) = oneshot::channel(); - // TODO(guyn): refactor this test to pass proposals through the correct channels. let (mut proposal_receiver_sender, proposal_receiver_receiver) = mpsc::channel(CHANNEL_SIZE); expect_validate_proposal(&mut context, Felt::TWO); @@ -214,7 +212,6 @@ async fn run_consensus_sync_cancellation_safety() { let proposal_handled = Arc::new(Notify::new()); let (decision_tx, decision_rx) = oneshot::channel(); - // TODO(guyn): refactor this test to pass proposals through the correct channels. let (mut proposal_receiver_sender, proposal_receiver_receiver) = mpsc::channel(CHANNEL_SIZE); expect_validate_proposal(&mut context, Felt::ONE); @@ -287,7 +284,6 @@ async fn test_timeouts() { mock_register_broadcast_topic().unwrap(); let mut sender = mock_network.broadcasted_messages_sender; - // TODO(guyn): refactor this test to pass proposals through the correct channels. let (mut proposal_receiver_sender, mut proposal_receiver_receiver) = mpsc::channel(CHANNEL_SIZE);