Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send actionable notification whenever something fails in project model #6239

Closed
mkaput opened this issue Aug 20, 2024 · 2 comments
Closed

Send actionable notification whenever something fails in project model #6239

mkaput opened this issue Aug 20, 2024 · 2 comments
Labels
ide This issue refers to CairoLS or editor extensions
Milestone
LS: New Project M...

Comments

@mkaput
Copy link
Contributor

mkaput commented Aug 20, 2024

When something fails in project model code, send a notification to the user instead of just logging an error.

See all TODO comments that look like this one:

cairo/crates/cairo-lang-language-server/src/lib.rs

Line 583 in 0f0f721

// TODO(mkaput): Send a notification to the language client.

@mkaput mkaput added the ide This issue refers to CairoLS or editor extensions label Aug 20, 2024
@mkaput mkaput added this to the LS: New Project Model milestone Aug 20, 2024
@Arcticae Arcticae closed this as completed Nov 7, 2024
@Arcticae
Copy link
Collaborator

Arcticae commented Nov 7, 2024

@piotmag769 please link a PR

@piotmag769
Copy link
Collaborator

#6596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ide This issue refers to CairoLS or editor extensions
Projects
CairoLS
Archived in project
Milestone
LS: New Project Model
Development

No branches or pull requests
3 participants
@mkaput @Arcticae @piotmag769