Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSyncingStats test fails when RPC returns false #1248

Open
wojciechos opened this issue Oct 16, 2024 · 1 comment
Open

getSyncingStats test fails when RPC returns false #1248

wojciechos opened this issue Oct 16, 2024 · 1 comment
Labels
Type: bug Something isn't working

Comments

@wojciechos
Copy link

Describe the bug
The getSyncingStats test fails when the RPC returns false. The test expects an object matching the SyncingStatus schema, but doesn't handle the case where false is returned, which is a valid response.

To Reproduce

  1. Run the RPC provider tests using a synced Juno node(then result should be false). E.g:
    TEST_RPC_URL=https://free-rpc.nethermind.io/sepolia-juno npm run test -- -t getSyncingStats

  2. Observe the failure

Expected behavior
Test should pass when starknet_syncing results is false

Desktop (please complete the following information):

  • Starknet.js v6.15.0
  • Network testnet
  • Node version v22.8.0
@wojciechos wojciechos added the Type: bug Something isn't working label Oct 16, 2024
@od-hunter
Copy link

Hi @wojciechos , is this open for contribution?

@starknet-io starknet-io deleted a comment Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants