Replies: 1 comment 1 reply
-
@kathirsvn I'd advise against it. Mongoose 7 drops support for callbacks, so if you implement Mongoose's "if any argument is a function, use it as a callback" logic you'll have to remove it very soon. It also isn't necessary, because Mongoose only uses 1 function signature for driver calls. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi @vkarpov15
Should we check the call back function param as in https://github.com/Automattic/mongoose/blob/7fbb440c4fa2edf878052d717fbf6407c4381142/lib/query.js#L2574 in all of the APIs and reset the optional params received in a function, accordingly? I think last when we discussed you mentioned, it's a nice to have feature. Should we create an issue and track for implementing later?
cc: @amorton @jeffreyscarpenter
Beta Was this translation helpful? Give feedback.
All reactions