Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to simplify testing -- separate server from logic #19

Open
brianru opened this issue Jul 31, 2019 · 1 comment
Open

Refactor to simplify testing -- separate server from logic #19

brianru opened this issue Jul 31, 2019 · 1 comment
Labels

Comments

@brianru
Copy link
Contributor

brianru commented Jul 31, 2019

It is currently very difficult if not impossible to test the logic of the language servers without starting a server and poking it with the server's request and notification methods. However, that makes it very difficult to isolate and test parts of the logic.

I think if we want to continue improving the functionality of each server, as opposed to just adding more servers, we need to build out a suite of unit-tests for each verifying completions and other features return what we want in a wide range of scenarios.

I would like to start by separating the language server protocol aspect from the underlying logic and state management in the servers.

What do you think @jmrog @anneeb ?

@jmrog
Copy link
Contributor

jmrog commented Aug 5, 2019

This sounds right to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants