Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed PR #65

Closed
MrMunki opened this issue Oct 11, 2021 · 2 comments
Closed

Failed PR #65

MrMunki opened this issue Oct 11, 2021 · 2 comments

Comments

@MrMunki
Copy link
Contributor

MrMunki commented Oct 11, 2021

Hi, I've tried a PR but the test is failing, not sure why as this wasn't changed. Could someone take a look?

#64

Thanks,

D

@pdmars
Copy link
Member

pdmars commented Oct 12, 2021

The tests just had a bit of a race condition which should be addressed on develop. If you rebase and rerun the tests it should be fixed.

@MrMunki
Copy link
Contributor Author

MrMunki commented Oct 12, 2021

Thanks for that, it's passed the test now :)

@MrMunki MrMunki closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants